fix: unclear 'show no data' #3204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-3204--dhis2-maps.netlify.app |
6 flaky tests on run #3239 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Routes > loads download page currentAnalyticalObject (hash) |
Screenshots
|
|
dataDownload.cy.js • 1 flaky test • e2e-chrome-parallel-2.41
| Test | Artifacts | |
|---|---|---|
| Data Download > downloads data from an event layer |
Screenshots
|
|
interpretations.cy.js • 1 flaky test • e2e-chrome-parallel-2.41
| Test | Artifacts | |
|---|---|---|
| Interpretations > view interpretation after creating a map |
Screenshots
|
|
routes.cy.js • 1 flaky test • e2e-chrome-parallel-2.40
| Test | Artifacts | |
|---|---|---|
| Routes > loads download page currentAnalyticalObject (hash) |
Screenshots
|
|
interpretations.cy.js • 1 flaky test • e2e-chrome-parallel-2.40
| Test | Artifacts | |
|---|---|---|
| Interpretations > view interpretation after creating a map |
Screenshots
|
|
The first 5 flaky specs are shown, see all 6 specs in Cypress Cloud.
Review all test suite changes for PR #3204 ↗︎
Automatically merged.
jenniferarnesen
approved these changes
Jun 6, 2024
dhis2-bot
added a commit
that referenced
this pull request
Jun 13, 2024
## [100.5.5](v100.5.4...v100.5.5) (2024-06-13) ### Bug Fixes * **translations:** sync translations from transifex (dev) ([#3237](#3237)) ([8e9a46d](8e9a46d)) * unclear 'show no data' ([#3204](#3204)) ([ec24ca0](ec24ca0)) * use improved rich text editor from analytics (DHIS2-15522) ([#3236](#3236)) ([3c842d4](3c842d4)) * **translations:** sync translations from transifex (dev) ([230dc08](230dc08)) * **translations:** sync translations from transifex (dev) ([83393cb](83393cb))
|
🎉 This PR is included in version 100.5.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement DHIS2-15799
Linked maps-gl PR: dhis2/maps-gl#573
Update text "Show no data" in
NoDataColorcomponent.Add logic to display "no data" text if
valueis missing inPopupcomponent.Before:
Screenshare.-.2024-05-15.2_37_54.PM.mp4
After: ("no data" has been changed to "No data")
Screenshare.-.2024-05-16.2_03_10.AM.mp4