-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show version debug info and update notification in profile menu [LIBS-176] [LIBS-344] #1153
Conversation
🚀 Deployed on https://pr-1153--dhis2-ui.netlify.app |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
I'm going to go ahead and merge this to |
components/header-bar/src/profile-menu/instance-and-app-info.js
Outdated
Show resolved
Hide resolved
When tests pass I'm going to merge this to beta for testing in-situ |
@cooper-joe should we de-duplicate the |
# [8.5.0-beta.1](v8.4.16...v8.5.0-beta.1) (2022-10-03) ### Features * show version debug info and update notification in profile menu [LIBS-176] [LIBS-344] ([#1153](#1153)) ([9e23f18](9e23f18))
Yeah I think it's fine for now. There doesn't seem to be an agreed format (I see both DHIS2 2.x and DHIS 2.x all over our website), so I think for clarity let's keep as is 👍. |
# [8.5.0](v8.4.17...v8.5.0) (2022-10-06) ### Features * show version debug info and update notification in profile menu [LIBS-176] [LIBS-344] ([#1153](#1153)) ([9e23f18](9e23f18))
Implements LIBS-176
Implements LIBS-344
Requires dhis2/app-runtime#1252
Blocks dhis2/app-platform#748
Builds on #795 (credit to @Mohammer5) and the previous update notification flow in app-platform (credit to @KaiVandivier)
Description
This implements two features
It also moves to using
useConfig
for the app name (rather than a prop) but maintains backwards compatibility.Builds on and supersedes the good work by @Mohammer5 in #795
Known issues
Checklist
[ ] API docs are generated(no API docs for HeaderBar, currently)All points above should be relevant for feature PRs. For bugfixes, some points might not be relevant. In that case, just check them anyway to signal the work is done.
Screenshots
https://user-images.githubusercontent.com/947888/192796030-948971a6-cdda-4be6-b5cc-447a697e3b09.mov
(note that some small details have changed since this video was taken)