feat: show version debug info and update notification in profile menu [LIBS-176] [LIBS-344] #1153

amcgee · 2022-09-22T18:33:11Z

Requires dhis2/app-runtime#1252
Blocks dhis2/app-platform#748

Builds on #795 (credit to @Mohammer5) and the previous update notification flow in app-platform (credit to @KaiVandivier)

Description

This implements two features

Debug info (DHIS2 and application versions) in headerbar
Update Available notification

It also moves to using useConfig for the app name (rather than a prop) but maintains backwards compatibility.

Builds on and supersedes the good work by @Mohammer5 in #795

Known issues

Haven't yet fixed Cypress tests, they should be much simpler than in feat(headerbar): display instance's & app's info in profile menu - LIBS-176 #795 because we don't load the systemInfo data dynamically.
Styling might need some improvements
We eventually would like to either (1) show a tooltip indicating that a click on debug MenuItem will copy to clipboard or (2) show a dialog with extended debug info and an explicit copy action

Checklist

~~[ ] API docs are generated~~ (no API docs for HeaderBar, currently)
Tests were added
Storybook demos were added

All points above should be relevant for feature PRs. For bugfixes, some points might not be relevant. In that case, just check them anyway to signal the work is done.

Screenshots

https://user-images.githubusercontent.com/947888/192796030-948971a6-cdda-4be6-b5cc-447a697e3b09.mov
(note that some small details have changed since this video was taken)

…tions in PR

…ooks

… item

…t props

dhis2-bot · 2022-09-22T18:41:04Z

🚀 Deployed on https://pr-1153--dhis2-ui.netlify.app

cypress · 2022-09-22T19:56:32Z

Test summary

566 • 0 • 0 • 0

Run details


Project	ui
Status	Passed
Commit	`7cbbdb9`
Started	Oct 3, 2022 12:33 PM
Ended	Oct 3, 2022 12:42 PM
Duration	09:03 💡
OS	Linux Ubuntu - 20.04
Browser	Electron 94

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

amcgee · 2022-09-26T13:57:45Z

I'm going to go ahead and merge this to beta for testing in-situ

components/header-bar/src/profile-menu/instance-and-app-info.js

components/header-bar/src/profile-menu/update-notification.js

amcgee · 2022-10-03T12:14:52Z

Updated for all the various edge cases - a bit silly when we don't expect these to happen, but now they're covered (and tested in Cypress)

Normal:

App version unknown:

Instance version unknown:

App name unknown:

App name and version unknown:

Update available:

Update available with app name unknown:

amcgee · 2022-10-03T12:21:56Z

When tests pass I'm going to merge this to beta for testing in-situ

amcgee · 2022-10-03T12:29:35Z

@cooper-joe should we de-duplicate the DHIS2 2.x ? Probably fine for now, but a bit redundant (always our problem here)

# [8.5.0-beta.1](v8.4.16...v8.5.0-beta.1) (2022-10-03) ### Features * show version debug info and update notification in profile menu [LIBS-176] [LIBS-344] ([#1153](#1153)) ([9e23f18](9e23f18))

dhis2-bot · 2022-10-03T13:36:29Z

🎉 This PR is included in version 8.5.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

cooper-joe · 2022-10-04T07:48:26Z

@cooper-joe should we de-duplicate the DHIS2 2.x ? Probably fine for now, but a bit redundant (always our problem here)

Yeah I think it's fine for now. There doesn't seem to be an agreed format (I see both DHIS2 2.x and DHIS 2.x all over our website), so I think for clarity let's keep as is 👍.

# [8.5.0](v8.4.17...v8.5.0) (2022-10-06) ### Features * show version debug info and update notification in profile menu [LIBS-176] [LIBS-344] ([#1153](#1153)) ([9e23f18](9e23f18))

dhis2-bot · 2022-10-06T14:40:21Z

🎉 This PR is included in version 8.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Mohammer5 and others added 16 commits November 23, 2021 11:18

refactor(headerbar profile): use functional component instead of class

4e5a2fa

feat(headerbar): add instance- & app-infos to profile menu

6185b5d

docs(headerbar): add story with instance- & app-infos in profile menu

42db34e

refactor(headerbar use instance info): simplify hook

6c0b8c0

refactor(headerbar instance infos): adjust styles according to sugges…

400b810

…tions in PR

chore: fix linter issues

b54ddb9

test(header bar): add tests for "useInstanceInfo" & "useOnDocClick" h…

c299272

…ooks

fix(profile menu): remove comma between app name and app version

1de06c6

fix(profile menu): remove hover style from instance and app info menu…

0a83b93

… item

refactor(headerbar instance infos): omit "version" word in instance info

21532f1

refactor(instance and app infos): make user-selectable & add data-tes…

cfbd4f1

…t props

test(instance and app infos): add cypress tests

434c04d

chore(linter and prettier): fix issues

5237b5c

Merge remote-tracking branch 'origin/master' into LIBS-176

054eaa2

feat: use context to fetch version info, add copy action

b712041

feat: support update notification in profile menu

bf95076

amcgee requested review from Mohammer5 and KaiVandivier September 22, 2022 18:33

amcgee marked this pull request as draft September 22, 2022 18:35

dhis2-bot temporarily deployed to netlify September 22, 2022 18:41 Inactive

amcgee mentioned this pull request Sep 22, 2022

feat: headerbar update notification [LIBS-344] dhis2/app-platform#748

Merged

chore: fix linting errors

3bf79b1

dhis2-bot temporarily deployed to netlify September 22, 2022 19:43 Inactive

chore: fix cypress tests

df44aa6

amcgee mentioned this pull request Sep 22, 2022

feat(headerbar): display instance's & app's info in profile menu - LIBS-176 #795

Closed

5 tasks

dhis2-bot temporarily deployed to netlify September 22, 2022 20:37 Inactive

chore: use MenuDivider instead of custom border

e5c962d

dhis2-bot temporarily deployed to netlify September 22, 2022 20:56 Inactive

dhis2-bot temporarily deployed to netlify September 26, 2022 11:33 Inactive

amcgee changed the base branch from master to beta September 26, 2022 13:53

style: formatting

027d18b

amcgee marked this pull request as ready for review September 26, 2022 13:56

dhis2-bot temporarily deployed to netlify September 26, 2022 14:04 Inactive

Mohammer5 reviewed Sep 27, 2022

View reviewed changes

components/header-bar/src/profile-menu/instance-and-app-info.js Outdated Show resolved Hide resolved

Mohammer5 reviewed Sep 27, 2022

View reviewed changes

components/header-bar/src/profile-menu/update-notification.js Outdated Show resolved Hide resolved

feat: add debug info modal

034fe96

dhis2-bot temporarily deployed to netlify September 28, 2022 13:49 Inactive

style: formatting

091e322

dhis2-bot temporarily deployed to netlify September 28, 2022 14:32 Inactive

chore: add cypress tests

dabca36

dhis2-bot temporarily deployed to netlify October 3, 2022 12:04 Inactive

fix: support app version with missing app name

7cbbdb9

dhis2-bot temporarily deployed to netlify October 3, 2022 12:27 Inactive

style: format

8fd4bff

amcgee merged commit 9e23f18 into beta Oct 3, 2022

amcgee deleted the LIBS-344 branch October 3, 2022 12:46

dhis2-bot temporarily deployed to netlify October 3, 2022 13:10 Inactive

dhis2-bot added the released on @beta label Oct 3, 2022

dhis2-bot added the released label Oct 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: show version debug info and update notification in profile menu [LIBS-176] [LIBS-344] #1153

feat: show version debug info and update notification in profile menu [LIBS-176] [LIBS-344] #1153

amcgee commented Sep 22, 2022 •

edited

Loading

dhis2-bot commented Sep 22, 2022 •

edited

Loading

cypress bot commented Sep 22, 2022 •

edited

Loading

amcgee commented Sep 26, 2022

amcgee commented Oct 3, 2022

amcgee commented Oct 3, 2022

amcgee commented Oct 3, 2022

dhis2-bot commented Oct 3, 2022

cooper-joe commented Oct 4, 2022

dhis2-bot commented Oct 6, 2022

feat: show version debug info and update notification in profile menu [LIBS-176] [LIBS-344] #1153

feat: show version debug info and update notification in profile menu [LIBS-176] [LIBS-344] #1153

Conversation

amcgee commented Sep 22, 2022 • edited Loading

Description

Known issues

Checklist

Screenshots

dhis2-bot commented Sep 22, 2022 • edited Loading

cypress bot commented Sep 22, 2022 • edited Loading

Test summary

Run details

amcgee commented Sep 26, 2022

amcgee commented Oct 3, 2022

amcgee commented Oct 3, 2022

amcgee commented Oct 3, 2022

dhis2-bot commented Oct 3, 2022

cooper-joe commented Oct 4, 2022

dhis2-bot commented Oct 6, 2022

amcgee commented Sep 22, 2022 •

edited

Loading

dhis2-bot commented Sep 22, 2022 •

edited

Loading

cypress bot commented Sep 22, 2022 •

edited

Loading