Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement methods for additional fields #14

Merged
merged 10 commits into from
May 20, 2019

Conversation

tobiasschweizer
Copy link
Contributor

@tobiasschweizer tobiasschweizer commented May 20, 2019

This PR adds methods for additional Marc fields.

  • 024: e-manuscripta (instead of 856)
  • 610 / 710: Körperschaften
  • 300: Physische Beschreibung
  • 500: Anmerkung
  • 520: Inhaltsangabe
  • 041: Sprache standardisiert

closes #12

Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything allright, as far as I can tell

@tobiasschweizer tobiasschweizer merged commit cb8b0c0 into master May 20, 2019
@tobiasschweizer tobiasschweizer deleted the wip/12-additional-fields branch May 20, 2019 17:42
@BalduinLandolt
Copy link
Collaborator

@tobiasschweizer One small remark: Technically, this PR does not close #12 , just priority A of that issue.

Could you either adjust that accordingly, or add another issue for priority B?

@tobiasschweizer tobiasschweizer mentioned this pull request May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New fields
2 participants