This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Reading View -- send data collected from frontend to the database #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segmentResponseArray now includes an object per question, SegmentQuestion component and sumbit button were removed. Text is automatically updated when in text box
… of fields into its own function
…building of fields into its own function" This reverts commit 8c479d2.
This reverts commit 8a48876.
…ton is pressed" This reverts commit bab694b.
This reverts commit a593a03.
…realized they are better on their own branch. Branch disable_back_and_next_buttons has that code now. Sorry for all of the revert commits. I'm not quite sure how to elegantly return to an old commit in github desktop.
…mit/rereading into reading_view_global_questions
…ances" This reverts commit 95d0dd4.
…new instances"" This reverts commit b790679.
verifies that post is called, turns request to response
THANKS all for this work -- pretty huge. I'm going to take over this branch and clean this up / merge it into master tomorrow morning. If you see anything here that needs clarification before I do that, please make a note on those thread or DM me on Slack. |
Will merge #107 in first as that work involves adding some features that this PR then refactors. |
ryaanahmed
approved these changes
Nov 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging! Lots of great work here, thanks all.
There's still a major bug to squash before this is ready for primetime -- will make an issue -- but merging this now, as it's big progress in the right direction.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #62 #63