Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement to package loading instructions #7

Closed
AndrewSwann opened this issue May 27, 2016 · 1 comment
Closed

Improvement to package loading instructions #7

AndrewSwann opened this issue May 27, 2016 · 1 comment

Comments

@AndrewSwann
Copy link

AndrewSwann commented May 27, 2016

This is just a comment on improving the suggested method of loading the code when installed via el-get or the package manager. Currently the README suggests

(let ((benchmark-init.el "/path/to/el-get/benchmark-init/benchmark-init.el"))
  (when (file-exists-p benchmark-init.el)
    (load benchmark-init.el)))

however the load function has options to not report an error if the file exists. Also by default it will start by trying to add extensions .elc and .el to the file name. I suggest you shorten the code to

(let ((benchmark-init-el "/path/to/el-get/benchmark-init/benchmark-init.el")
  (load benchmark-init-el 'no-error nil 'no-suffix))

or even to a single load statement

(load "/path/to/el-get/benchmark-init/benchmark-init.el"
  'no-error nil 'no-suffix)
dholm added a commit that referenced this issue Nov 26, 2017
Use the simplified elisp for installation via el-get as suggested by
AndrewSwann in issue #7.
@dholm
Copy link
Owner

dholm commented Nov 26, 2017

@AndrewSwann Thanks, documentation fixed!

@dholm dholm closed this as completed Nov 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants