Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata.Picture() returning invalid image #62

Closed
deluan opened this issue Apr 5, 2020 · 4 comments
Closed

Metadata.Picture() returning invalid image #62

deluan opened this issue Apr 5, 2020 · 4 comments

Comments

@deluan
Copy link

deluan commented Apr 5, 2020

If I try to extract the album art from the attached mp3, I get an invalid image. This is what I get when running tag against the file:

$ tag thoh.mp3
Metadata Format: ID3v2.4
File Type: MP3
 Title: The House Of House (Thomas Schumacher Remix)
 Album: Spiritika 25
 Artist: Cherrymoon Trax
 Composer:
 Genre: Techno
 Year: 2019
 Track: 13 of 0
 Disc: 0 of 0
 Picture: Picture{Ext: , MIMEType: >}, Type: , Description: mage/jpeg, Data.Size: 240139}
 Lyrics:

Note the invalid mime type and description. It's worth to note that I can successfully extract the image with ffmpeg, and iTunes also displays the image with no issues.

thoh.mp3.zip

Thanks

@AlphaJack
Copy link

Converting the tags to ID3v2.3 works, it seems to be a problem with ID3v2.4 in MP3. The Data.Size attribute differs:

$ tag thoh.mp3
Metadata Format: ID3v2.3
File Type: MP3
 Title: The House Of House (Thomas Schumacher Remix)
 Album: Spiritika 25
 Artist: Cherrymoon Trax
 Composer:
 Genre: Techno
 Year: 2019
 Track: 13 of 0
 Disc: 0 of 0
 Picture: Picture{Ext: jpg, MIMEType: image/jpeg, Type: Cover (front), Description: , Data.Size: 237423}
 Lyrics:
 Comment:

I've also noticed that both ID3v2.3 and ID3v2.4 can't be read from AIFF files, can you add support for them?

@deluan
Copy link
Author

deluan commented Apr 6, 2020

Doesn't seem to be an issue with ALL ID3v2.4 tags. The attached file works as expected:

$ tag jam.mp3
Metadata Format: ID3v2.4
File Type: MP3
 Title: Art School
 Album: Fire & Skill - The Songs Of The Jam
 Artist: Silver Sun
 Composer:
 Genre: Rock
 Year: 1999
 Track: 5 of 12
 Disc: 1 of 1
 Picture: Picture{Ext: jpg, MIMEType: image/jpeg, Type: Cover (front), Description: , Data.Size: 69211}
 Lyrics:

jam.mp3.zip

@deluan
Copy link
Author

deluan commented Apr 11, 2020

This was fixed with PR #63
Thanks a lot!

deluan added a commit to navidrome/navidrome that referenced this issue Apr 11, 2020
@deluan
Copy link
Author

deluan commented Apr 20, 2020

This is working as expected. Not sure if you want me to close the issue, but feel free to do so.
Thanks a lot for fixing this

@dhowden dhowden closed this as completed Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants