id3v2: Read and use frame data length indicator #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably fixes #62 |
wader
commented
Apr 6, 2020
| @@ -283,6 +284,10 @@ func readID3v2Frames(r io.Reader, offset uint, h *id3v2Header) (map[string]inter | |||
| } | |||
| size-- | |||
| } | |||
|
|
|||
| if flags.DataLengthIndicator { | |||
There was a problem hiding this comment.
Spec says this about compression and data length indicator flags:
This flag indicates whether or not the frame is compressed. A 'Data Length Indicator' byte MUST be included in the frame.
Maybe should be flags.Compression || flags.DataLengthIndicator here also to be safe?
wader
commented
Apr 6, 2020
| @@ -283,6 +284,10 @@ func readID3v2Frames(r io.Reader, offset uint, h *id3v2Header) (map[string]inter | |||
| } | |||
| size-- | |||
| } | |||
|
|
|||
| if flags.DataLengthIndicator { | |||
| size = dataLengthIndicator | |||
There was a problem hiding this comment.
Maybe all this could move into the condition above... but then there is size-- in encryption case ... move them around? don't know
|
Thanks for digging into this, I had a quick look yesterday but didn't get this far! Will try to look through in the next few hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.