Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy addon - not working in FF55 #1096

Closed
Silur opened this issue Jul 18, 2017 · 8 comments
Closed

Legacy addon - not working in FF55 #1096

Silur opened this issue Jul 18, 2017 · 8 comments
Assignees

Comments

@Silur
Copy link

Silur commented Jul 18, 2017

Describe the issue

Not working in Firefox 55, all ads get past, settings menu buttons have no text, firefox considers it as legacy (since all browsers use a common extension language now)

One or more specific URLs where the issue occurs

Any Url

Screenshot in which the issue can be seen

Steps for anyone to reproduce the issue

(Please be as detailed as possible)

Your settings

  • OS/version: ArchLinux x86_64
  • Browser/version: FIrefox 55
  • AdNauseam version: 3.3.331
@greysonevins
Copy link

I am getting the issue as well. AdNauseam works with ff 54 but not with 55.0b it looks like.
image

Label reads

@greysonevins
Copy link

greysonevins commented Jul 18, 2017

It looks like FF is transitioning to a web-extension API that uBO has addressed with "The webext version of uBO is a hybrid, a webext wrapped into a thin layer legacy one, necessary for a seamless transition." See gorhill's comment on gorhill/issues/2576 @dhowe

See also gorhill/issues/2728 and gorhill/issues/622 and Mozilla blog response on transition.

With the current dev tools on the master branch "run-webext" does not come as legacy and run-ff works but says legacy. It may be that we solved the issue with merging with uBlock a while back but will need verification @dhowe @cqx931.

@Silur @dhowe When I started with a fresh version of firefox v55.0b, I was unable to reproduce this issue. v3.3.331 works for me.

Currently, the store version v3.3.331 is not compatible with beyond ff 54. We will need to work on this further @Silur. Thank you for your patience. For now, you can build ADN from source or use a past version of Firefox like v54. See the documentation here

@dhowe
Copy link
Owner

dhowe commented Jul 19, 2017

I see the legacy warning, this is not a problem ...
image

But I don't see the other problems you mention.

image

Please get to the bottom of this, starting with fresh browsers, and using only standard setup instructions

@dhowe
Copy link
Owner

dhowe commented Jul 19, 2017

'Legacy' should only be a warning, until FF57.

See this note, and follow the links...

@greysonevins
Copy link

@dhowe you were right. In setting up a Firefox, the problem resolved itself. I'm not able to duplicate the issue now.

@dhowe
Copy link
Owner

dhowe commented Jul 19, 2017

Is your note above incorrect then, @greysonevins ?

Currently, the store version v3.3.331 is not compatible with beyond ff 54. We will need to work on this further @Silur. Thank you for your patience. For now, you can build ADN from source or use a past version of Firefox like v54.

@greysonevins
Copy link

@dhowe edits made to the comment.

@dhowe dhowe closed this as completed Jul 28, 2017
@dhowe
Copy link
Owner

dhowe commented Jul 28, 2017

closing as unverifiable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants