Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webext] Both webext addons have a yellow "LEGACY" badge #2576

Closed
Darkspirit opened this issue May 1, 2017 · 4 comments
Closed

[webext] Both webext addons have a yellow "LEGACY" badge #2576

Darkspirit opened this issue May 1, 2017 · 4 comments
Labels

Comments

@Darkspirit
Copy link

Darkspirit commented May 1, 2017

https://dxr.mozilla.org/mozilla-central/search?q=addon.legacy.label&redirect=false
screenshot_20170501_124438

As those addons are webext-only and not webext-hybrid as you are planning it for the future, I am confused.
#622 (comment)
If those webext addons are already the hybrids, I do not understand why there are legacy and hybrid-legacy addons, but not webextension-only addons. (Importing the webext-only chromium addons into Nightly does not work which I neither would expect).

@gorhill
Copy link
Owner

gorhill commented May 1, 2017

The webext version of uBO is a hybrid, a webext wrapped into a thin layer legacy one, necessary for a seamless transition. If you want the label to be different for this case, this is a Firefox issue.

@Darkspirit
Copy link
Author

Darkspirit commented May 1, 2017

Okay, Thank you! The thin legacy layer must be removed until August (Nightly 57) anyway, so I think this label is technically correct and okay for this time. Then I will now try to remove that legacy layer for myself to feel better :D
Edit: Nice, thank you for making it that easy. 🎉 (Just compress the contents of the webextension folder as zip and import it into Nightly.)

@gorhill
Copy link
Owner

gorhill commented May 1, 2017

If I find the free time, I will bring back the pure webext version like it used to be before I converted to hybrid.

@RalfJung
Copy link

RalfJung commented Jun 22, 2017

If I find the free time, I will bring back the pure webext version like it used to be before I converted to hybrid.

Will using the old make-webext still "just work" or is it necessary to update that file?

Also, any reason that current releases don't include the webext.xpi any more? I just built it from source, and so far it did not explode...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants