Type error in onPortDisconnect function

[mneunomne]

There is this minor bug occurring which I didn't find the reason for it yet, but I can't detect any consequences of it yet:

Error in event handler: TypeError: Cannot read properties of null (reading 'name')

AdNauseam/platform/common/vapi-background.js

Lines 855 to 857 in f075a90

	onPortDisconnect: function(port) {
	this.ports.delete(port.name);
	},

[dhowe]

in any case, we should always be checking for undefined before accessing properties/functions

[mneunomne]

This is not AdNauseam code, so the issue is more like there is something in our code that is not adapted well to the way in which uBlock closes the ports.

[mneunomne]

It seems that this is just happening when opening the menu, and no issues seems to arise from that. I handled the exception with a message when debugging is enabled. I'll close once merged.

[mneunomne]

Closing

[mneunomne]

Finally found out why this was happening. Using the debugger was not helping so I just had to use many consolelog to eventually figure out it was a case switch with a break instead of a return in the getCostPerClick function implemented on #2162.

[mneunomne]

Fixed, closing.