Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual representation of ads that will not be visited #958

Closed
dhowe opened this issue Mar 23, 2017 · 6 comments
Closed

Visual representation of ads that will not be visited #958

dhowe opened this issue Mar 23, 2017 · 6 comments
Assignees
@mushon
Labels
Needs-design PRIORITY: Medium
Milestone
Release 3.5

Comments

@dhowe
Copy link
Owner

dhowe commented Mar 23, 2017

either b/c of click-probability or if they were manually visited

-- currently we have 3 colors for (unvisited, visited, and failed)
@dhowe dhowe added this to the Release 3.4 milestone Mar 23, 2017
@mushon
Copy link
Collaborator

mushon commented Mar 24, 2017

maybe yellow?
I wonder if we should have an animation for them though, not sure.

@dhowe
Copy link
Owner Author

dhowe commented Mar 24, 2017

works for me... though maybe we need a mouse-over for each of the states ?

@mushon
Copy link
Collaborator

mushon commented Mar 24, 2017 via email

@dhowe
Copy link
Owner Author

dhowe commented Mar 24, 2017

the color should be both... the mouse-over is just an idea, not sure if it is or isnt necessary in either

@dhowe dhowe modified the milestone: Release 3.4 Sep 13, 2017
@dhowe dhowe added this to the Release 3.5 milestone Sep 22, 2017
@dhowe
Copy link
Owner Author

dhowe commented Sep 22, 2017 •
edited
Loading

We might also differentiate (with color) between ads that will not be visited for different reasons:

  1. click-probability
  2. DNT (see also Ads on DNT pages should be labeled in menu, vault, and vault-inspector #1168)
  3. if they were manually visited

@dhowe dhowe mentioned this issue Sep 22, 2017
Open
@cqx931 cqx931 mentioned this issue Dec 9, 2017
Closed
6 tasks
@cqx931
Copy link
Collaborator

cqx931 commented Dec 9, 2017

close this, move to #1168

@cqx931 cqx931 closed this as completed Dec 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mushon mushon

Labels
Needs-design PRIORITY: Medium
Projects
None yet
Milestone
Release 3.5
Development

No branches or pull requests
3 participants
@mushon @dhowe @cqx931