Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A slight bit of crucial maintenance #1489

Merged
merged 4 commits into from May 15, 2019
Merged

A slight bit of crucial maintenance #1489

merged 4 commits into from May 15, 2019

Conversation

DandelionSprout
Copy link

@DandelionSprout DandelionSprout commented May 14, 2019

Greetings, Dandelion Sprout here, the maintainer of Dandelion Sprout's Nordic Filters and a general adblocking enthusiast.

Having learned about AdNauseam yesterday, I decided to make this pull request to see how much this extension was being worked on, and whether or not the project intended to strive for functional equivalence with uBlock Origin. What it does, is:

  • Synchronised the regional lists with those of uBO.
    • Most crucially, Finnish Addition to Easylist should've been removed half a year ago, as it was first ousted from major adblockers due to the maintainer making blocking rules against labour union sites as a whole all of a sudden, followed by him removing all entries in his list.
  • Fixed the Chrome download link in the readme.
  • Changed some links in the readme from HTTP to HTTPS.
  • Removed the CONTRIBUTING.md file, as it quite obviously didn't apply to the AdNauseam repo.

"lang": "pl",
"contentURL": "https://raw.githubusercontent.com/MajkiIT/polish-ads-filter/master/polish-adblock-filters/adblock.txt",
"supportURL": "https://github.com/MajkiIT/polish-ads-filter/issues",
"instructionURL": "https://github.com/MajkiIT/polish-ads-filter#polish-filters-for-adblock-ublock-origin--adguard"
},
"POL-2": {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@dhowe
Copy link
Owner

dhowe commented May 14, 2019

Thanks @DandelionSprout. We are indeed still working actively on ADN and would love to get it in sync with UBO, though a) we are quite strapped for dev resources, and b) we stay generally a few releases behind UBO. We are about to release a new version of ADN, based on UBO v1.17.0, which should include your PR. But any addtl thoughts on how better to stay in sync with the various list maintainers would be great.

@DandelionSprout
Copy link
Author

DandelionSprout commented May 14, 2019

based on UBO v1.17.0, which should include your PR.

Nope! Various changes have been done to the uBO version of assets.json after 1.17.0, including the removal of Finnish Addition to EasyList and the strangely maintained ABP Japanese Filters. After all, I based this pull request on AdNauseam's assets.json file as it appeared after the Merge branch 'upstream1.17.0' into merge1.17.0-titled commit. From my occasional involvement in uBO, I can also tell that any changes done to the assets.json file would go live to all users of all version numbers within minutes, as that particular file is version-independent.

I also see no reason to not update the GitHub repo's readme links either.

@dhowe
Copy link
Owner

dhowe commented May 14, 2019

Sorry, I meant that once I check and merge this PR, it will be included in our next release.

@DandelionSprout
Copy link
Author

...Aaaaah. That makes more sense. I too am sorry for originally misreading you.

@DandelionSprout
Copy link
Author

DandelionSprout commented May 14, 2019

As for how to get in touch with maintainers, a handful of maintainers and uBO team members can be found and contacted at DandelionSprout/adfilt#7, and there's been some very recent small attempts at establishing a forum at https://hub.filterlists.com/ as well.

@cqx931 cqx931 merged commit 6e80aef into dhowe:master May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants