Combine database calls? #1

Closed
lephyrius opened this Issue Mar 19, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@lephyrius

I notice that u do separate database calls for the results?
Any reason for it?

I have a feeling that combining all the database-queries into one will be more efficient.
The thing is that I use soulmate for it's efficiency and no reason to slow it down in some other end..
Maybe provide a way to only get the ID:s from the results in search_by method?

@dhruvasagar

This comment has been minimized.

Show comment
Hide comment
@dhruvasagar

dhruvasagar Mar 19, 2013

Owner

Makes absolute sense, strangely I did the same optimization where I am using this but I forgot to update it here in the gem. Will do so by tonight. Thanks a lot!

Owner

dhruvasagar commented Mar 19, 2013

Makes absolute sense, strangely I did the same optimization where I am using this but I forgot to update it here in the gem. Will do so by tonight. Thanks a lot!

@dhruvasagar

This comment has been minimized.

Show comment
Hide comment
@dhruvasagar

dhruvasagar Apr 19, 2013

Owner

Hey sorry for the late fix, I had forgotten about this, busy in other things.

Do your info, I had to modify supermodel and add support for a 'where' method for a model to be able to run my tests. It's a basic implementation but works for most basic use cases. I have sent a pull request for the same, but until that is accepted we'll have to use my fork of it, i've overridden the supermodel gem with my fork in Gemfile. Will remove that once the pull request gets approved.

Owner

dhruvasagar commented Apr 19, 2013

Hey sorry for the late fix, I had forgotten about this, busy in other things.

Do your info, I had to modify supermodel and add support for a 'where' method for a model to be able to run my tests. It's a basic implementation but works for most basic use cases. I have sent a pull request for the same, but until that is accepted we'll have to use my fork of it, i've overridden the supermodel gem with my fork in Gemfile. Will remove that once the pull request gets approved.

chengjunzhan pushed a commit to chengjunzhan/soulmate_rails that referenced this issue Jun 18, 2013

Jim Zhan
Merge pull request #1 from gmanley/master
Make the redis database be namespaced to app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment