Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for Buku Tags in Search #19

Merged
merged 4 commits into from
Aug 14, 2022
Merged

feat: Support for Buku Tags in Search #19

merged 4 commits into from
Aug 14, 2022

Conversation

traumweh
Copy link
Contributor

Adds the config-key buku_include_tags (boolean, default false) to also include buku tags in search and displayer.

I'm not that familiar with lua, but I tried to keep the footprint minimal.

- config-key `buku_include_tags = true` to activate
@traumweh
Copy link
Contributor Author

Added the "tags" column to bookmarks.db and used some default values (starting and ending with comma because that's how buku seems to do it).

But I honestly don't know enough about testing with buster/vusted to include tests for the config-key.

Copy link
Owner

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution and patience! LGTM 🎉

@dhruvmanila dhruvmanila linked an issue Aug 14, 2022 that may be closed by this pull request
@dhruvmanila dhruvmanila merged commit 5a47fe0 into dhruvmanila:main Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Search for Buku Tags
2 participants