Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for extra args to be passed to the git commit command #17

Merged
merged 3 commits into from
Mar 19, 2023

Conversation

nader-zouaoui
Copy link
Contributor

As the name of the PR explains I added a few lines to support some extra arguments to be passed to the git commit command.

For example, say I want to execute git commit with --no-verify using oc I simply cannot do it,

What I added makes you able to do oc --no-verify and it translates to git commit -m ${generatedText} --no-verify

@nader-zouaoui
Copy link
Contributor Author

I could add a small doc section for it if approved

Copy link
Owner

@di-sukharev di-sukharev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smart smart :)

approved! could you add some docs to readme?

@nader-zouaoui
Copy link
Contributor Author

Sure bro give me a minute

@nader-zouaoui
Copy link
Contributor Author

@di-sukharev here's the Doc

@di-sukharev
Copy link
Owner

@nader-zouaoui could you please change the base to dev from master and solve conflicts if any? will merge when done. AWESOME JOB <3

@nader-zouaoui nader-zouaoui changed the base branch from master to dev March 16, 2023 15:04
@di-sukharev
Copy link
Owner

@nader-zouaoui really awesome feature! could you solve the conflict pls and let's merge it

@di-sukharev di-sukharev mentioned this pull request Mar 17, 2023
@nader-zouaoui
Copy link
Contributor Author

@di-sukharev here you go !

@di-sukharev di-sukharev merged commit d793bf1 into di-sukharev:dev Mar 19, 2023
zen0bit pushed a commit to oSoWoSo/opencommit that referenced this pull request Apr 12, 2023
…nd (di-sukharev#17)

* feat: Add support for extra args to be passed to the git commit command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants