fix for: section producing incorrect results #322 #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The section instance of SegTree seems to be correct, but the instances for Located, Trail, and Trail' Line all used the default definition which uses splitAtParam instead of SegTree's implementation of section. The default definition of splitAtParam is only correct for types which consist of a single segment or are parametrized by arclength (rather than with each segment having equal weight).
|
Makes sense, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The section instance of SegTree seems to be correct, but the
instances for Located, Trail, and Trail' Line all used the
default definition which uses splitAtParam instead of SegTree's
implementation of section. The default definition of splitAtParam
is only correct for types which consist of a single segment or are
parametrized by arclength (rather than with each segment having
equal weight).