Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New scaleInvPrim function #71

Merged
merged 9 commits into from Apr 17, 2013
Merged

New scaleInvPrim function #71

merged 9 commits into from Apr 17, 2013

Conversation

byorgey
Copy link
Member

@byorgey byorgey commented Jan 27, 2013

This is a simple change, and another step along the way to nice support for arrows. However, it's perhaps a bit controversial because it gives scale-invariant things zero size, just like text objects (I can't see any other way to do it). Please take a look and ascertain whether you think this makes sense/is acceptable.

@byorgey
Copy link
Member Author

byorgey commented Jan 28, 2013

Hmm, as @fryguybob points out, this doesn't interact properly with freeze; I'll have to give that some thought. Please don't merge yet.

@byorgey byorgey mentioned this pull request Feb 7, 2013
@byorgey
Copy link
Member Author

byorgey commented Apr 17, 2013

OK, I think this is ready to merge now. I've addressed the problems with freeze by adding a new IsPrim class (see diagrams/diagrams-core#37, which this depends on). The nice thing is that this requires no changes to any backends: I've tested with both SVG and cairo and it seems to work as intended.

fryguybob added a commit that referenced this pull request Apr 17, 2013
@fryguybob fryguybob merged commit a3cf199 into master Apr 17, 2013
@fryguybob fryguybob deleted the scaleinv-prim branch April 17, 2013 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants