Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't emit Dialogic.timeline_ended until Timeline#clean has been called #2146

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

iscke
Copy link
Contributor

@iscke iscke commented Mar 21, 2024

this fixes a bug where starting a timeline in a callback attached to Dialogic.timeline_ended will lock, since Timeline#clean fires a frame after it's called (and after timeline_ended is emitted), which will then disconnect the signals on the new timeline.

(easy repro:

func _ready():
    Dialogic.start("whatever.dtl")
    Dialogic.timeline_ended.connect(Dialogic.start.bind("whatever.dtl")

causes the timeline to run once, and then to start a second time without input working.)

@CakeVR CakeVR added the Bug 🐞 Something isn't working label Mar 26, 2024
@Jowan-Spooner
Copy link
Collaborator

Looks good to me. Thanks!

@Jowan-Spooner Jowan-Spooner merged commit fd5f820 into dialogic-godot:main Mar 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants