Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the version field automatically during serialization #10

Closed
wokalski opened this issue Jun 24, 2021 · 2 comments
Closed

Set the version field automatically during serialization #10

wokalski opened this issue Jun 24, 2021 · 2 comments

Comments

@wokalski
Copy link
Contributor

wokalski commented Jun 24, 2021 •
edited

Currently the version field needs to be set explicitly which is a source of potential bugs (as experienced in our product :) )
@tsnobip
Copy link
Collaborator

tsnobip commented Jul 15, 2021

@wokalski does this mean we should not require to have a version field in the ATD schema?

@wokalski
Copy link
Contributor Author

Good question!!! I was thinking about this. The nice thing about the current setup is that you can use those files in vanilla atd.

tsnobip added a commit that referenced this issue Jul 15, 2021
@tsnobip @quernd
auto-fill version field (fixes #10)
476bc7d 
Co-authored-by: Daniel Quernheim <quernd@users.noreply.github.com>
tsnobip added a commit that referenced this issue Jul 16, 2021
@tsnobip @quernd
auto-fill version field (fixes #10)
63c48f2 
Co-authored-by: Daniel Quernheim <quernd@users.noreply.github.com>
tsnobip added a commit that referenced this issue Jul 16, 2021
@tsnobip @quernd
auto-fill version field (fixes #10)
aeb1280 
Co-authored-by: Daniel Quernheim <quernd@users.noreply.github.com>
tsnobip added a commit that referenced this issue Jul 16, 2021
@tsnobip @quernd
auto-fill version field (fixes #10)
3bcbb2b 
Co-authored-by: Daniel Quernheim <quernd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wokalski @tsnobip