-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some logging tidy-up #1034
Labels
Comments
@Anthchirp I'm wondering how adding a prefix like |
dagewa
added a commit
that referenced
this issue
Dec 1, 2019
dagewa
added a commit
that referenced
this issue
Dec 16, 2019
dagewa
added a commit
that referenced
this issue
Dec 16, 2019
dagewa
added a commit
that referenced
this issue
Dec 16, 2019
* Prefix logger.warning messages with "WARNING:" * Merge functionality with ElapsedFormatter. Do not change formatting of console messages. Colours are preferable. * Update util/log.py * Suggestions from @Anthchirp - Use the margin for the "WARN:" message - Rename formatter * Warning or above * News Completes another checkpoint for #1034 Co-Authored-By: Markus Gerstel <2102431+Anthchirp@users.noreply.github.com>
dagewa
added a commit
that referenced
this issue
Dec 17, 2019
Highlighting is done automatically by the formatter. Closes #1034
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
logger.warning
is used in a few places in the codebase. Use is not very consistent:logger.warning("*** WARNING: no reflections in job %d ***", index)
logger.warning("Restraints will be ignored for scan_varying=True")
logger.warning("Warning: Experiment crystals differ. Using first experiment crystal for file-level data.")
There are also warnings that aren't
warning
slogger.info("Warning: %d reference spots were not matched to predictions" % (len(unmatched)))
It would be nice to have a consistent style. If
logger.warning
took care of the*** WARNING
/Warning:
or whatever prefix, this would help.Capitalisation -
Warning: experiment
notWarning: Experiment
preferredFinally,
one call per message please
The text was updated successfully, but these errors were encountered: