Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge dials.show show_shared_models and dials.find_shared_models #1070

Closed
Anthchirp opened this issue Dec 12, 2019 · 1 comment · Fixed by #2063
Closed

merge dials.show show_shared_models and dials.find_shared_models #1070

Anthchirp opened this issue Dec 12, 2019 · 1 comment · Fixed by #2063
Assignees
@graeme-winter @Anthchirp
Labels
enhancement

Comments

@Anthchirp
Copy link
Member

It seems that this essentially does the same thing, albeit in a different form. Since PR #996 was merged, I suggest that dials.find_shared_models should be removed as it is then duplicate (and untested) functionality.

Originally posted by @rjgildea in #996 (comment)
@stale
Copy link

stale bot commented Aug 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. The label will be removed automatically if any activity occurs. Thank you for your contributions.

@stale stale bot added the stale issues that have not seen activity for a while label Aug 3, 2020
@stale stale bot removed the stale issues that have not seen activity for a while label Apr 6, 2022
Anthchirp added a commit that referenced this issue Apr 6, 2022
@Anthchirp
Retire dials.find_shared_models
5667dd1 
This command will now redirect users to `dials.show` in combination with the
`show_shared_models=True` option.

The command stub can be removed after the next DIALS release.

Closes #1070
@Anthchirp Anthchirp linked a pull request Apr 6, 2022 that will close this issue
Retire dials.find_shared_models #2063
Merged
Anthchirp added a commit that referenced this issue Apr 11, 2022
@Anthchirp
Retire dials.find_shared_models (#2063)
fa2abce 
This command will now redirect users to `dials.show` in combination with the
`show_shared_models=True` option.

The command stub can be removed after the next DIALS release.

Closes #1070
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@graeme-winter graeme-winter

@Anthchirp Anthchirp

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Retire dials.find_shared_models dials/dials
3 participants
@ndevenish @graeme-winter @Anthchirp