Use experiment identifiers from import #1086
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated version of a previous PR (#902).
The idea is the same, generate a unique (uuid) string identifier on import, do the same when discovering lattices upon indexing, and propagate through the processing (and checking each time so that files without identifiers still work for back compatibility). Most of the file changes are updating the flatten_reflections/flatten_experiments calls, to handle any order of input data from the command line.
At the moment, most programs don't really use the identifier to any particular benefit, that can come as part of future work as required.
I have also generated a uuid in the stills indexer as a demonstration, and checked that stills processing still completes fine (although there are possibly more complex workflows that i am not able to properly check?). Without the changes to
stills_indexer.py
, no identifiers are generated (at any point in stills processing), and the processing completes the same. I would like to ask for feedback from @asmit3 or @phyy-nx as to which option is preferred:stills_indexer.py
unchanged, so that no identifiers are generated for stills at present (although this may cause issues if using the regular indexer for stills which is sometimes done?)stills_indexer.py
.