Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stills_indexer: Add a deterministic option for experiment identifiers #1864

Closed
wants to merge 8 commits into from

Conversation

dwpaley
Copy link
Contributor

@dwpaley dwpaley commented Aug 25, 2021

No description provided.

@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #1864 (e90423d) into main (fc216c8) will increase coverage by 0.03%.
The diff coverage is 13.33%.

❗ Current head e90423d differs from pull request most recent head b49dc97. Consider uploading reports for the commit b49dc97 to get more accurate results

@@            Coverage Diff             @@
##             main    #1864      +/-   ##
==========================================
+ Coverage   67.10%   67.14%   +0.03%     
==========================================
  Files         619      617       -2     
  Lines       70002    69532     -470     
  Branches     9732     9671      -61     
==========================================
- Hits        46977    46686     -291     
+ Misses      21059    20906     -153     
+ Partials     1966     1940      -26     

@Anthchirp
Copy link
Member

Reference to previous identifier discussions: PRs #902 and #1086

@dwpaley
Copy link
Contributor Author

dwpaley commented Aug 26, 2021

Thanks, @Anthchirp . According to the previous discussion and the unimplemented "timestamp" identifier option, it looks like a feature like this had been intended. I think this PR meets the goal of the original timestamp idea, but also (1) handles multiple lattices in a shot with unique identifiers for each, and (2) assumes nothing about the image format.

@dwpaley
Copy link
Contributor Author

dwpaley commented Jan 20, 2022

After cctbx/dxtbx#438 we think this is no longer needed because we don't have to delete imagesets during cctbx.xfel.merge jobs. Thus we can always look at the imageset if we want to connect processed data to the original images, and no longer need to duplicate that information in the identifier.

@dwpaley dwpaley closed this Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants