We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This is spun out from xia2/xia2#430
export_mtz from command_line/export_mtz.py is treated as library code by dials.scale:
export_mtz
command_line/export_mtz.py
dials.scale
dials/command_line/scale.py
Line 148 in 5058b42
However a ValueError raised here is caught and the program simply exits, which is confusing
ValueError
dials/command_line/export.py
Lines 263 to 266 in 5058b42
dials.util.export_mtz
The text was updated successfully, but these errors were encountered:
Move sys.exit out of potential library functions.
2a22125
Raise exceptions there instead, to be caught in the __main__ block. Fixes #1205
dagewa
Successfully merging a pull request may close this issue.
This is spun out from xia2/xia2#430
export_mtz
fromcommand_line/export_mtz.py
is treated as library code bydials.scale
:dials/command_line/scale.py
Line 148 in 5058b42
However a
ValueError
raised here is caught and the program simply exits, which is confusingdials/command_line/export.py
Lines 263 to 266 in 5058b42
Maybe
export_mtz
should not be swallowing thisValueError
, or/and maybedials.scale
should be usingdials.util.export_mtz
instead.The text was updated successfully, but these errors were encountered: