Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gemmi to dependencies? #1266

Closed
Anthchirp opened this issue May 17, 2020 · 6 comments · Fixed by #1506
Closed

add gemmi to dependencies? #1266

Anthchirp opened this issue May 17, 2020 · 6 comments · Fixed by #1506

Comments

@Anthchirp
Copy link
Member

The Gemmi library (https://github.com/project-gemmi/gemmi) is developed by CCP4 and Global Phasing, and offers among other things a faster CIF parser and MTZ read/write capability in both C++ and Python bindings.

The package is well-documented, licensed under MPLv2 and LGPL. It is an active project with proper releases and is packaged on conda-forge.

@dagewa
Copy link
Member

dagewa commented May 17, 2020

I'm keen. I've just started using gemmi and have found it very easy to get into

@dagewa
Copy link
Member

dagewa commented May 19, 2020

Another reason to use gemmi is that it handles unmerged mmcif, which will be useful when preparing files for deposition in future. #281 is a moving target and it would be useful to offload the heavy lifting.

@dagewa
Copy link
Member

dagewa commented Jun 3, 2020

"Gemmi handles mmcif so we don't have to" is a strong argument to me.
https://project-gemmi.github.io/wasm/to_mmcif/

@graeme-winter
Copy link
Contributor

I am not at all hostile to this. Personally I am not bothered about mmCIF, but I do wonder what it would do regarding regular CIF? Better MTZ file wrangling could be useful 🙂

@dagewa
Copy link
Member

dagewa commented Jun 3, 2020

I have used it to read regular cif, with great success (it is very fast). The issue with mmCIF is that it is required for deposition and eventually will include unmerged data, including the mapping between multiple crystal data and the scaled/merged dataset that only the scaling program really knows about. It's true that "eventually" might be still a long way off, but I can see a possible need for DIALS tool to aid deposition, by writing the reflections part into the mmCIF from refinement.

@Anthchirp
Copy link
Member Author

Sort of blocked by project-gemmi/gemmi#42 and conda-forge/gemmi-feedstock#20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants