-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refine_bravais_settings hangs on very large reflection tables #1274
Comments
<- has just stubbed toes on same |
Discussion: dumping reflection shoeboxes before spawning subprocesses would probably make this go away |
graeme-winter
added a commit
that referenced
this issue
Jun 24, 2020
Fixes #1274 - dump the shoeboxes as soon as possible in dials.refine_bravais_settings, which massively reduces the object size to be sent across pickle link
graeme-winter
added a commit
that referenced
this issue
Jun 24, 2020
Drop the shoeboxes in refine_bravais_settings Fixes #1274 - dump the shoeboxes as soon as possible in dials.refine_bravais_settings, which massively reduces the object size to be sent across pickle link Co-authored-by: Nicholas Devenish <ndevenish@gmail.com>
Anthchirp
pushed a commit
that referenced
this issue
Jun 24, 2020
Drop the shoeboxes in refine_bravais_settings Fixes #1274 - dump the shoeboxes as soon as possible in dials.refine_bravais_settings, which massively reduces the object size to be sent across pickle link Co-authored-by: Nicholas Devenish <ndevenish@gmail.com>
graeme-winter
added a commit
that referenced
this issue
Jun 24, 2020
Drop the shoeboxes in refine_bravais_settings Fixes #1274 - dump the shoeboxes as soon as possible in dials.refine_bravais_settings, which massively reduces the object size to be sent across pickle link Co-authored-by: Nicholas Devenish <ndevenish@gmail.com>
Merged
ndevenish
added a commit
that referenced
this issue
Jul 6, 2020
Features -------- - Developer tool: On posix systems, sending SIGUSR2 to DIALS commands will now print a stack trace (#1277) Bugfixes -------- - HTML reports: Plot bin centres instead bin minimum for d_min line plots vs. resolution (#1323) - `dials.export`: Fix inconsistency in mtz export when given a non-reference (e.g. I2 or primitive) setting (#1279) - `dials.refine_bravais_settings`: Fix crash with large (>2gb) reflection tables and reduce memory use (#1274) - `dials.scale`: Fix bug in outlier rejection code causing misidentification of outliers (with outlier_rejection=standard). - `dials.scale`: Fix outlier rejection formula to avoid overconfidence in spuriously low values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
[Copied from email from @jmp1985]
@rjgildea posted the output from running with current:
The text was updated successfully, but these errors were encountered: