Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warnings.warn is not highlighted on the console #1401

Closed
dagewa opened this issue Sep 13, 2020 · 0 comments · Fixed by #1402
Closed

warnings.warn is not highlighted on the console #1401

dagewa opened this issue Sep 13, 2020 · 0 comments · Fixed by #1402

Comments

@dagewa
Copy link
Member

dagewa commented Sep 13, 2020

Oh I somehow missed that above. Yes, it does show to the user, but it is not highlighted in yellow like logger.warning is.

Originally posted by @dagewa in #1393 (comment)
Anthchirp added a commit that referenced this issue Sep 13, 2020
@Anthchirp
Log warnings to console and log files
0cad4ad 
when logging is set up through dials.

Resolves #1401
@Anthchirp Anthchirp mentioned this issue Sep 13, 2020
Merged
Anthchirp added a commit that referenced this issue Sep 20, 2020
@Anthchirp
Log warnings to console and log files
86a53ff 
when logging is set up through dials.

Resolves #1401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Log warnings to console and log files dials/dials
1 participant
@dagewa