Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phenix dispatchers in dials release #1576

Closed
ndevenish opened this issue Feb 2, 2021 · 7 comments · Fixed by #2032
Closed

phenix dispatchers in dials release #1576

ndevenish opened this issue Feb 2, 2021 · 7 comments · Fixed by #2032
Labels
stale issues that have not seen activity for a while

Comments

@ndevenish
Copy link
Member

ndevenish commented Feb 2, 2021 •
edited

e.g.

$ wget https://github.com/dials/dials/releases/download/v3.3.2/dials-v3-3-2-linux-x86_64.tar.xz
$ tar xf dials-v3-3-2-linux-x86_64.tar.xz
$ cd dials-installer/
$ ./install --prefix=..
$ . ../dials-v3-3-2/dials_env.sh
$ phenix.<tab>
Display all 105 possibilities? (y or n)

(reported by Aaron)
@graeme-winter
Copy link
Contributor

Pretty sure we used to strip them out right?

@dagewa
Copy link
Member

dagewa commented Feb 2, 2021

They are not supposed to be created in the first place
https://github.com/dials/dials/blob/master/installer/bootstrap.py#L1015

@ndevenish
Copy link
Member Author

They aren't supposed to be generated at all with --skip_phenix_dispatchers, which apparently we are passing (and don't show on my development install)

@graeme-winter
Copy link
Contributor

I'll wager side-effect of upstream change 🤔

@ndevenish
Copy link
Member Author

It's apparently unset rather than ignored:

$ libtbx.show_env build/libtbx_env | grep skip
                   'skip_phenix_dispatchers': False,

@dagewa
Copy link
Member

dagewa commented Mar 26, 2021

Billy suggested that --skip-phenix-dispatchers would need adding to reconfigure

@stale
Copy link

stale bot commented Sep 22, 2021

This issue has been automatically marked as stale because it has not had recent activity. The label will be removed automatically if any activity occurs. Thank you for your contributions.

@stale stale bot added the stale issues that have not seen activity for a while label Sep 22, 2021
ndevenish added a commit to ndevenish/dials-fork that referenced this issue Mar 11, 2022
@ndevenish
Don't generate phenix dispatchers on DIALS installation
7c3a1bf 
Although these aren't generated for development installs, upon installation
libtbx.configure is called without --skip_phenix_dispatchers. Since there
isn't a way to do this using the base installer, move the logic into our
subclass.

Fixes dials#1576
@ndevenish ndevenish mentioned this issue Mar 11, 2022
Merged
ndevenish added a commit that referenced this issue Mar 11, 2022
@ndevenish
Don't generate phenix dispatchers on DIALS installation (#2032)
3048ab1 
Although these aren't generated for development installs, upon installation
libtbx.configure is called without --skip_phenix_dispatchers. Since there
isn't a way to do this using the base installer, move the logic into our
subclass.

Fixes #1576
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale issues that have not seen activity for a while
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't generate phenix dispatchers on DIALS installation ndevenish/dials-fork
3 participants
@ndevenish @graeme-winter @dagewa