Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev.dials.thing #1703

Closed
dagewa opened this issue May 14, 2021 · 3 comments
Closed

dev.dials.thing #1703

dagewa opened this issue May 14, 2021 · 3 comments

Comments

@dagewa
Copy link
Member

dagewa commented May 14, 2021

I was just using dev.dials.sort_reflections, thinking that it was useful and wondering why it was behind a dev.dials. dispatcher. There are 7 dev.dials. from DIALS (and many others from dials_scratch). The ones from DIALS are:

Reflection wrangling utilities

  • dev.dials.sort_reflections
  • dev.dials.merge_reflection_lists

Other data processing analysis jiffies

  • dev.dials.find_bad_pixels
  • dev.dials.csv

Tutorial build scripts

  • dev.dials.generate_tutorial_text
  • dev.dials.make_sphinx_html

Introspection

  • dev.dials.show_extensions

I believe the first two classes should graduate from dev.dials.thing to just dials.thing. That is, if it is in DIALS and does something with diffraction data it should be dials..

@rjgildea
Copy link
Contributor

I think historically dev.dials.* has been used to signal "not tested or actively supported". If any are graduated to dials.* I would suggest we should at a minimum add a test (if none exists).

dev.dials.csv can probably be removed - we (Diamond) now use dials.export format=json in its place.

@dagewa
Copy link
Member Author

dagewa commented May 14, 2021

sort_reflections and merge_reflection_lists both have tests. I don't think find_bad_pixels has one. Is this script useful?

@dagewa
Copy link
Member Author

dagewa commented Jul 2, 2021

This was supposed to have been closed when #1708 was merged

@dagewa dagewa closed this as completed Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants