Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dials.reindex allows reindexing to a left-handed cell #1779

Closed
dagewa opened this issue Jul 1, 2021 · 2 comments · Fixed by #2068
Closed

dials.reindex allows reindexing to a left-handed cell #1779

dagewa opened this issue Jul 1, 2021 · 2 comments · Fixed by #2068

Comments

@dagewa
Copy link
Member

dagewa commented Jul 1, 2021

dials.reindex refined.expt refined.refl change_of_basis_op=-h,-k,-l

works without failure or warning, but the result crashes refinement, quite reasonably:

dials.refine reindexed.expt reindexed.refl
...
RuntimeError: Please report this error to dials-support@lists.sourceforge.net: dxtbx Internal Error: /home/fcx32934/sw/cctbx/modules/dxtbx/model/crystal.h(432): DXTBX_ASSERT(detail::is_r3_rotation_matrix(U)) failure.
@stale
Copy link

stale bot commented Apr 3, 2022

This issue has been automatically marked as stale because it has not had recent activity. The label will be removed automatically if any activity occurs. Thank you for your contributions.

@stale stale bot added the stale issues that have not seen activity for a while label Apr 3, 2022
@dagewa
Copy link
Member Author

dagewa commented Apr 6, 2022

It looks like this has been fixed, or at least the error has now moved into dials.reindex itself:

$ dials.reindex refined.expt refined.refl change_of_basis_op=-h,-k,-l
The following parameters have been modified:

change_of_basis_op = "-h,-k,-l"
input {
  experiments = refined.expt
  reflections = refined.refl
}

Traceback (most recent call last):
  File "/home/fcx32934/sw/cctbx/build/../modules/dials/command_line/reindex.py", line 380, in <module>
    run()
  File "/home/fcx32934/sw/cctbx/conda_base/lib/python3.9/contextlib.py", line 79, in inner
    return func(*args, **kwds)
  File "/home/fcx32934/sw/cctbx/build/../modules/dials/command_line/reindex.py", line 336, in run
    experiments = reindex_experiments(
  File "/home/fcx32934/sw/cctbx/build/../modules/dials/command_line/reindex.py", line 152, in reindex_experiments
    cryst_reindexed = cryst_reindexed.change_basis(cb_op)
RuntimeError: Please report this error to dials-support@lists.sourceforge.net: dxtbx Internal Error: /home/fcx32934/sw/cctbx/modules/dxtbx/src/dxtbx/model/crystal.h(437): DXTBX_ASSERT(detail::is_r3_rotation_matrix(U)) failure.

@stale stale bot removed the stale issues that have not seen activity for a while label Apr 6, 2022
ndevenish pushed a commit that referenced this issue May 4, 2022
Friendlier error message when failing because of attempting to reindex
to a left-handed cell.

Fixes #1779
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant