Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refinement of the beam does not update the polarisation vector #1939

Closed
dagewa opened this issue Nov 24, 2021 · 1 comment
Closed

Refinement of the beam does not update the polarisation vector #1939

dagewa opened this issue Nov 24, 2021 · 1 comment
Assignees
@dagewa

Comments

@dagewa
Copy link
Member

dagewa commented Nov 24, 2021

Spotted in cctbx/dxtbx#454, but this is a dials.refine problem. Changing the beam direction outside the plane of polarisation should change the direction of the polarisation normal vector.
@dagewa dagewa self-assigned this Nov 24, 2021
dagewa added a commit that referenced this issue Nov 26, 2021
@dagewa
Update polarisation normal vector when refining a Beam
8b8d4dc 
Typically, the beam direction is refined only in the X-Z plane,
while the polarisation normal vector is along Y, so in most cases
for MX this makes no differnce. However the beam can be refined
around two angles, and in those cases would have become
inconsistent before this change. Fixes #1939
@dagewa
Copy link
Member Author

dagewa commented Jan 6, 2022

Was supposed to have been auto-closed by 8b8d4dc

@dagewa dagewa closed this as completed Jan 6, 2022
@ndevenish ndevenish reopened this Jan 14, 2022
This was referenced Mar 31, 2022
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dagewa dagewa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ndevenish @dagewa