Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dials.scale crashing if datasets are removed during the processing. #2045

Closed
jbeilstenedmands opened this issue Mar 29, 2022 · 0 comments · Fixed by #2046
Closed

dials.scale crashing if datasets are removed during the processing. #2045

jbeilstenedmands opened this issue Mar 29, 2022 · 0 comments · Fixed by #2046
Assignees
@jbeilstenedmands
Labels
dials.scale Affects dials.scale

Comments

@jbeilstenedmands
Copy link
Contributor

For multi-crystal processing (particularly small-wedge/ssx), dials.scale can sometimes remove datasets during processing, if all reflections get marked as bad. A user reported a crash due to this, and I also saw similar recently for ssx processing. The issue is that all of the internal datastructures are not updated properly.
@jbeilstenedmands jbeilstenedmands added the dials.scale Affects dials.scale label Mar 29, 2022
@jbeilstenedmands jbeilstenedmands self-assigned this Mar 29, 2022
jbeilstenedmands added a commit that referenced this issue Mar 29, 2022
@jbeilstenedmands
Avoid referencing issues into experimentlist. Fixes #2045.
7ef5349 
Also make sure internal datastuctures are consistent.
@jbeilstenedmands jbeilstenedmands mentioned this issue Mar 29, 2022
Merged
jbeilstenedmands added a commit that referenced this issue Mar 29, 2022
@jbeilstenedmands
Fix dials.scale crash when datasets removed internally (#2046)
6ab1c71 
Add test to display broken behaviour

Avoid referencing issues into experimentlist. Fixes #2045.

Also make sure internal datastuctures are consistent.
ndevenish pushed a commit that referenced this issue Mar 30, 2022
@jbeilstenedmands @ndevenish
Fix dials.scale crash when datasets removed internally (#2046)
6bfad2f 
Add test to display broken behaviour

Avoid referencing issues into experimentlist. Fixes #2045.

Also make sure internal datastuctures are consistent.
ndevenish pushed a commit that referenced this issue Mar 30, 2022
@jbeilstenedmands @ndevenish
Fix dials.scale crash when datasets removed internally (#2046)
30c9f4c 
Add test to display broken behaviour

Avoid referencing issues into experimentlist. Fixes #2045.

Also make sure internal datastuctures are consistent.
DiamondLightSource-build-server added a commit that referenced this issue Mar 30, 2022
@DiamondLightSource-build-server
DIALS 3.9.1
9508fb3 
Bugfixes
--------

- ``dials.scale``: Fix crash when a dataset is filtered out during the scaling process (issue #2045).
Merged
DiamondLightSource-build-server added a commit that referenced this issue Mar 30, 2022
@DiamondLightSource-build-server
DIALS 3.8.4
6f2dac2 
Bugfixes
--------

- ``dials.scale``: Fix crash when a dataset is filtered out during the scaling process (issue #2045).
Closed
DiamondLightSource-build-server added a commit that referenced this issue Mar 30, 2022
@DiamondLightSource-build-server
DIALS 3.9.1
94459c6 
Bugfixes
--------

- ``dials.scale``: Fix crash when a dataset is filtered out during the scaling process (issue #2045).
DiamondLightSource-build-server added a commit that referenced this issue Mar 30, 2022
@DiamondLightSource-build-server
DIALS 3.9.1
7b5294b 
Bugfixes
--------

- ``dials.scale``: Fix crash when a dataset is filtered out during the scaling process (issue #2045).
jbeilstenedmands added a commit to jbeilstenedmands/dials that referenced this issue Mar 30, 2022
@jbeilstenedmands
Avoid referencing issues into experimentlist. Fixes dials#2045.
4714b7a 
Also make sure internal datastuctures are consistent.
DiamondLightSource-build-server added a commit that referenced this issue Mar 31, 2022
@DiamondLightSource-build-server
DIALS 3.9.1
9e749e8 
Bugfixes
--------

- ``dials.scale``: Fix crash when a dataset is filtered out during the scaling process (issue #2045).
DiamondLightSource-build-server added a commit that referenced this issue Mar 31, 2022
@DiamondLightSource-build-server
DIALS 3.9.1
1444408 
Bugfixes
--------

- ``dials.scale``: Fix crash when a dataset is filtered out during the scaling process (issue #2045).
DiamondLightSource-build-server added a commit that referenced this issue Mar 31, 2022
@DiamondLightSource-build-server
DIALS 3.9.1
d81aa22 
Bugfixes
--------

- ``dials.scale``: Fix crash when a dataset is filtered out during the scaling process (issue #2045).
DiamondLightSource-build-server added a commit that referenced this issue Apr 1, 2022
@DiamondLightSource-build-server
DIALS 3.8.4
7f3c78b 
Bugfixes
--------

- ``dials.scale``: Fix crash when a dataset is filtered out during the scaling process (issue #2045).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbeilstenedmands jbeilstenedmands

Labels
dials.scale Affects dials.scale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix dials.scale crash when datasets removed internally dials/dials
1 participant
@jbeilstenedmands