Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Experiment ids' buttons in RLV don't do anything #407

Closed
Anthchirp opened this issue Jul 4, 2017 · 4 comments
Closed

'Experiment ids' buttons in RLV don't do anything #407

Anthchirp opened this issue Jul 4, 2017 · 4 comments

Comments

@Anthchirp
Copy link
Member

Steps to reproduce:
dials.reciprocal_lattice_viewer strong.pickle datablock.json with dataset with >1 sweeps. Click Experiment ids buttons to try and isolate data from one sweep. All data is shown.

This works with dials.reciprocal_lattice_viewer indexed.pickle experiments.json.

@Anthchirp Anthchirp changed the title 'Experiment ids' button in RLV don't do anything 'Experiment ids' buttons in RLV don't do anything Jul 4, 2017
@rjgildea
Copy link
Contributor

rjgildea commented Jul 4, 2017

The experiments id buttons shouldn't appear, and if they did, then I wouldn't expect them to do anything anyway as they are for selecting experiments (there are none in a datablock.json). Instead use the imageset id buttons:
$ dials.reciprocal_lattice_viewer $(libtbx.find_in_repositories dials_regression)/indexing_test_data/multi_sweep/SWEEP*/index/*import.json $(libtbx.find_in_repositories dials_regression)/indexing_test_data/multi_sweep/SWEEP*/index/*strong.pickle marker_size=50

Behaves as expected for me:
screen shot 2017-07-04 at 09 16 30
screen shot 2017-07-04 at 09 16 43

@Anthchirp
Copy link
Member Author

Sounds plausible, however:
dials.reciprocal_lattice_viewer /dls/tmp/wra62962/directories/jTdJHufE/*-4*
image

@Anthchirp
Copy link
Member Author

It does work on the regression data.

Anthchirp pushed a commit that referenced this issue Jul 4, 2017
…ps in single datablock.json/strong.pickle (fixed #407)
@Anthchirp
Copy link
Member Author

Fixed. Many thanks. Earmarked for 1.6.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants