Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

image viewer saturation shown on variance image #846

Closed
dagewa opened this issue Jul 12, 2019 · 0 comments
Closed

image viewer saturation shown on variance image #846

dagewa opened this issue Jul 12, 2019 · 0 comments
Labels
dials.image_viewer

Comments

@dagewa
Copy link
Member

dagewa commented Jul 12, 2019

The highlighting of pixels above the upper bound of the trusted_range should only occur for the normal image display, not for the variance image.

In this example, the image is capped at 8000 ADUs, but the variance values in the centre of the spot shown are >> 65535 (which is what the format class has set the upper trusted range bound to). The image viewer erroneously displays these with yellow overlay.
Screenshot from 2019-07-12 12-39-03
dagewa added a commit that referenced this issue Dec 1, 2019
@dagewa
Control display of overloaded pixels.
bd87eb8 
Introduce a variable, show_saturated. Set this to False when the image
type is "variance". Fixes #846
@dagewa dagewa mentioned this issue Dec 1, 2019
Merged
@dagewa dagewa closed this as completed in 9f8cd7d Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dials.image_viewer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dagewa