Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

algorithms/symmetry: This is not normal #919

Closed
Anthchirp opened this issue Sep 10, 2019 · 0 comments
Closed

algorithms/symmetry: This is not normal #919

Anthchirp opened this issue Sep 10, 2019 · 0 comments
Assignees

Comments

@Anthchirp
Copy link
Member

The function _normalisation is never called.
Flake8 highlighted this since the local variable normalisation is undefined.

I assume this is an oversight that happened during refactoring?

def _normalise(self):
if normalisation is None:
return
elif normalisation == "kernel":
normalise = self.kernel_normalisation
elif normalisation == "quasi":
normalise = self.quasi_normalisation
elif normalisation == "ml_iso":
normalise = self.ml_iso_normalisation
elif normalisation == "ml_aniso":
normalise = self.ml_aniso_normalisation
for i in range(int(flex.max(self.dataset_ids) + 1)):
logger.info("Normalising intensities for dataset %i" % (i + 1))
intensities = self.intensities.select(self.dataset_ids == i)
if i == 0:
normalised_intensities = normalise(intensities)
else:
normalised_intensities = normalised_intensities.concatenate(
normalise(intensities)
)
self.intensities = normalised_intensities.set_info(
self.intensities.info()
).set_observation_type_xray_intensity()

rjgildea added a commit that referenced this issue Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants