Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change dials.export to not require data verification by default #921

Closed
graeme-winter opened this issue Sep 10, 2019 · 3 comments
Closed

Change dials.export to not require data verification by default #921

graeme-winter opened this issue Sep 10, 2019 · 3 comments
Assignees
@graeme-winter

Comments

@graeme-winter
Copy link
Contributor

Only dials.export format=best requires it so we should move this to a different program. The best output also performs calculations and is not much used, so I think this is low cost with a high benefit that exporting data will just work - a common annoyance for users.
@graeme-winter
Copy link
Contributor Author

Side effect: retire DIALS_EXPORT_DO_NOT_CHECK_FORMAT 🙂

@graeme-winter graeme-winter self-assigned this Sep 10, 2019
graeme-winter added a commit that referenced this issue Sep 10, 2019
@graeme-winter
For #921 split out best
947b50a 
Splitting out export `format=best` to `export_best` as the one output
format which needs access to a full format so uses `check_format`=1 -
means we can retire DIALS_EXPORT_DO_NOT_CHECK_FORMAT
@graeme-winter
Copy link
Contributor Author

Working on this in dials-921 branch.

graeme-winter added a commit to xia2/xia2 that referenced this issue Sep 10, 2019
@graeme-winter
Following from dials-921 i.e. dials/dials#921 need API changes here too
62b152b
ndevenish added a commit to ndevenish/dials-fork that referenced this issue Sep 10, 2019
@ndevenish
Smartly decide whether check_format is needed in export
a866fc2 
It's only the BEST format that requires this for now, so everything else
can just ignore the images.

Fixes dials#921
@ndevenish
Copy link
Member

See also: #484, #639

graeme-winter added a commit that referenced this issue Sep 11, 2019
@graeme-winter
Fixes for #921 - split off dials.export format=best (#922)
cc4bb24 
* For #921 split out best

Splitting out export `format=best` to `export_best` as the one output format which needs access to a full format so uses `check_format`=1 - means we can retire DIALS_EXPORT_DO_NOT_CHECK_FORMAT. Includes cleaning up of PHIL API and removal of debug.
graeme-winter added a commit to xia2/xia2 that referenced this issue Sep 18, 2019
@graeme-winter
Following from dials-921 i.e. dials/dials#921 need API changes here t…
56fc42e 
…oo (#328)

* Following from dials-921 i.e. dials/dials#921 need API changes here too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@graeme-winter graeme-winter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ndevenish @graeme-winter