Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow choice of threshold algorithms #948

Merged
merged 2 commits into from
Oct 3, 2019
Merged

Conversation

dagewa
Copy link
Member

@dagewa dagewa commented Sep 26, 2019

The two dispersion algorithms share the same parameters but give
different results. This change allows the user to explore those
differences in the image viewer and to save out find_spots.phil
parameters including the algorithm choice.

The two dispersion algorithms share the same parameters but give
different results. This change allows the user to explore those
differences in the image viewer and to save out find_spots.phil
parameters including the algorithm choice.
@dagewa
Copy link
Member Author

dagewa commented Sep 26, 2019

As as aside, I noticed that a DispersionExtendedThresholdDebug (or DispersionThresholdDebug) is created every time one of the image type buttons is clicked, which contributes to slow navigation between the types of images. It would be better to create this only when the spot finding parameters are changed, and use the result to provide access to the various types of images, which are then already calculated.

Copy link
Contributor

@rjgildea rjgildea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and new feature appears to work. Only the sigma_s and threshold maps appear to be affected by the choice of algorithm, but I guess that is to be exepected?

@dagewa dagewa merged commit 7a42135 into master Oct 3, 2019
@dagewa dagewa deleted the viewer-threshold-choice branch October 3, 2019 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants