Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inefficient calculation of dispersion maps etc. #1213

Closed
dagewa opened this issue Mar 27, 2020 · 1 comment
Closed

Inefficient calculation of dispersion maps etc. #1213

dagewa opened this issue Mar 27, 2020 · 1 comment
Labels
dials.image_viewer

Comments

@dagewa
Copy link
Member

dagewa commented Mar 27, 2020

As as aside, I noticed that a DispersionExtendedThresholdDebug (or DispersionThresholdDebug) is created every time one of the image type buttons is clicked, which contributes to slow navigation between the types of images. It would be better to create this only when the spot finding parameters are changed, and use the result to provide access to the various types of images, which are then already calculated.

Originally posted by @dagewa in #948 (comment)
@dagewa
Copy link
Member Author

dagewa commented Mar 27, 2020

See also #1210 (comment)

@dagewa dagewa closed this as completed in 5ec61ed Mar 30, 2020
@dagewa dagewa mentioned this issue Apr 29, 2020
Closed
@phyy-nx phyy-nx mentioned this issue Jun 22, 2021
Merged
ndevenish pushed a commit that referenced this issue Jun 28, 2021
@graeme-winter
Fix image_viewer display of spotfinding intermediates for stills (#1761)
0db27df 
By simply computing a hash of the settings including the imageset this
still fixes #1734 whilst leaving #1213 fixed. Changing a request dict
to a simple hash of a tuple of the settings stops a future reader from
working through the code looking for where that request is sent to.

Also named the hash the same as the object which is hashed, to make the
connection clearer.
ndevenish pushed a commit that referenced this issue Jun 28, 2021
@graeme-winter @ndevenish
Fix image_viewer display of spotfinding intermediates for stills (#1761)
9cb8195 
By simply computing a hash of the settings including the imageset this
still fixes #1734 whilst leaving #1213 fixed. Changing a request dict
to a simple hash of a tuple of the settings stops a future reader from
working through the code looking for where that request is sent to.

Also named the hash the same as the object which is hashed, to make the
connection clearer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dials.image_viewer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dagewa