Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add agents tests to CICD #70

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Add agents tests to CICD #70

merged 1 commit into from
Jun 7, 2023

Conversation

alexpalms
Copy link
Member

No description provided.

@alexpalms
Copy link
Member Author

alexpalms commented Jun 3, 2023

@discordianfish As an additional comment, note that the test CICD file I have here, is very similar to the one I use in agents for their own CICD tests (https://github.com/diambra/agents/blob/fix-test-cicd/.github/workflows/test.yaml), so there is duplicated code.

We could probably import that file somehow, or call that CICD from within this one making sure that it installs this specific arena version (instead of the default one that is called there).

But maybe this is ok for now and we can avoid overthinking it.

Let me know!

@discordianfish
Copy link
Member

@discordianfish As an additional comment, note that the test CICD file I have here, is very similar to the one I use in agents for their own CICD tests (https://github.com/diambra/agents/blob/fix-test-cicd/.github/workflows/test.yaml), so there is duplicated code.

Yes, you can create a re-usable workflow: https://docs.github.com/en/actions/using-workflows/reusing-workflows#creating-a-reusable-workflow
And then call that from both the agents repo as well as from here

@alexpalms alexpalms merged commit a054ec9 into main Jun 7, 2023
8 checks passed
@alexpalms alexpalms deleted the add-agents-test branch June 7, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants