Refactor all generators #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit closes #9 by adding the new girgen/file.go FileGenerator, which is completely refactored from the ground up to be much smaller, cleaner and side effects-free. This commit closes #8 as well by introducing the SourceNamespace and CurrentNamespace API inside typeconv.Converter, which allows the converter to pick the right namespace for resolving and generating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors package
girgenand somewhat packagegirto bemore correct and concise, while also heavily decoupling generative components
away into a more reasonable package layout instead of a flat package layout.
When merged, this pull request will close #8, close #9, and solve part of #11 with the
refactoring introduced.
This pull request also changes the project's licensing from the more permissive
ISC license to a more copyleft approach. The details of this license is listed
in the new README.