add notebooks extras_require for running notebooks #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, shouldn't the notebook action install dependencies from |
|
Ah, I was confused with dianna-exploration, I was thinking of this PR: dianna-ai/dianna-exploration#145 I think it's useful to do this specifically for the notebooks, because then they also work on Binder. Binder allows users to try out the tutorial notebooks in the cloud for free. Anyway, maybe just merge this and we can change it later if we want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the notebooks action in main is failing. One of the issues is that it misses the torchvision requirement. This PR fixes that issue. Other issues still remain after this PR, for instance, the missing ferrari.jpg (of which the license is unclear).
Feel free to merge if you approve. It's a tiny PR anyway.