Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Followed Tags" are ordered by name desc #3986

Closed
prellele opened this issue Feb 18, 2013 · 6 comments
Closed

"Followed Tags" are ordered by name desc #3986

prellele opened this issue Feb 18, 2013 · 6 comments
Labels
backbone code 🐞 bug newcomer 🎨 ui
Milestone
0.1.1.0

Comments

@prellele
Copy link
Contributor

could be found on /stream and /tags/foo

Ordering should be by name, but asc
@jhass
Copy link
Member

jhass commented Feb 18, 2013

Calling the right sort function on the Backbone collection should be all that's needed.

@jhass jhass closed this as completed in 0cf1c2d Feb 24, 2013
Raven24 added a commit that referenced this issue Feb 24, 2013
@Raven24
Merge pull request #3997 from MrZYX/reversed_tag_followings
c984499 
Sort tag followings alphabetically, not in reverse, fixes #3986
jhass added a commit that referenced this issue Feb 24, 2013
@jhass
Sort tag followings alphabetically, not in reverse, fixes #3986
6bb644f
@denschub
Copy link
Member

denschub commented Mar 4, 2013

Check out my comment at 0cf1c2d#L1R6

@denschub denschub reopened this Mar 4, 2013
@fabianrbz
Copy link
Contributor

@denschub which version are you using? works for me on 25.0.1364.99. The only thing is, that when you add a new tag the list doesn't get sorted

@denschub
Copy link
Member

denschub commented Mar 4, 2013

I'm here with 25.0.1364.152. Are you sure it is working in your version? @SuperTux88 can confirm the issue. ;)

@SuperTux88
Copy link
Member

I had the bug on chromium-25.0.1364.84 and have it now on chromium-26.0.1410.19

@fabianrbz
Copy link
Contributor

@denschub @SuperTux88 I was able to reproduce it (only with more than 10 tags).
I found this issue in backbone that is related. I'll try to work on a solution

@fabianrbz fabianrbz mentioned this issue Apr 28, 2013
Merged
@jhass jhass closed this as completed May 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backbone code 🐞 bug newcomer 🎨 ui
Projects
None yet
Milestone
0.1.1.0
Development

No branches or pull requests
5 participants
@jhass @denschub @SuperTux88 @fabianrbz @prellele