Create a link to user's photos on their profile

[carolinagc]

The idea is to create a link, in the left side menu, to the photos uploaded by a user in their user profile, that can currently be seen in urls as

https://joindiaspora.com/people/diaspora_id/photos

and below the link to photos show the thumbnails of the last 3 photos

[jhass]

Like when you click on the current profile picture? ;)

Not sure about the thumbnails, got some mockups?

[goobertron]

I think it just needs to be made more obvious how to do what is already possible (by clicking on the profile photo). It's not intuitive that clicking a profile photo would show you all that user's uploaded photos.

A link saying 'Photos' wouldn't do any harm, or at least an obvious tool-tip on the profile photo.

However, this is not really so crucial until proper photo uploading, with albums, is introduced. At the moment all you get is all the photos uploaded to posts by that user, which have little coherence out of the context of their posts.

[juliaguar]

This is how it would look like:

[oliverbarnes]

I like it, fwiw. a photo feed is better than none, even if they're out of context... twitter has this

[Flaburgan]

Hm, the left column already display many things. A lot of people have a big biography, then the contacts in the same aspect than you, then possibly hundreds of pictures... It's too much I think. I'm in favor of simply add a "Photos" link, then a new page to display pictures. This new page could look like the previous beta profile, it was pretty nice to display pictures.

[carolinagc]

well the idea was to put the link to the photos, since the feature is already done but noone realizes. And as for the left side bar, we wanted to show just the last 6 photos, that can actually be set to 3 maybe.

[goobertron]

I've just checked and diasp.org already has a 'photos' link immediately under the profile photo. This I think is enough. As @Flaburgan says, on many profile pages the left-hand column is already full of different information, so I think adding more could lead to clutter.

[jhass]

What about replacing the (IMO useless) Last post link?

[carolinagc]

@MrZyx what do you mean by the Last post link? where?

[Flaburgan]

On the user profile, at the right of is diaspora handle.

[carolinagc]

Ahh ok .. had never seen it :-D and I agree is useless, you are already seeing the last post :)

[goobertron]

Excellent idea, as you say the 'last post' link is now useless.

[svbergerem]

@MrZyx Do you recommend replacing the 'last post' link with a 'photos' link? As a user who wants to see another users photos I think I wouldn't recognize that link. I'd prefer a 'photos' link in the left-hand column immediately under the profile picture. (without those 6 photos)

[Flaburgan]

I think we could re-use the camera icon instead of a plain text link.

[carolinagc]

I would delete the "last post" link but not reuse it for the photos, since is really hard to see :-(

Here is the current version of what we have done. Link on the left + only 3 thumbnails(there is no link to the photo) before user's contacts

[oliverbarnes]

@Flaburgan if a biography is big, perhaps it could be truncated after a certain number of lines, with an option to view more?

Personally, I find that thumbnails for photos (and perhaps video eventually?) makes the profile more engaging

[jhass]

I wouldn't truncate it. We could talk about moving the three thumbs over the bio, though I think I'm more with the "just a link" fraction.

[carolinagc]

I would also not truncate the bio.
Here is how it would like with the thumbs over the bio

And here with only the link to photos

[Flaburgan]

I would let the thumbnails after the bio.

We need to indicate that there is more pictores (it's not obvious when we see only 3) so I would propose to not link the title (and let it like gender, bio etc) but add a link the line after the pictures with "Show more pictures". 6 is also maybe better than 3.

[carolinagc]

True, not obvious that there might be more than 3 pics :) .. so your suggestions would look something like this (the space between Fotos and show all, I think should be smaller but this is the "br" quick way ;) )

[Flaburgan]

I'd put the link after the pictures.

[carolinagc]

[Flaburgan]

\o/

[svbergerem]

How about something like that? svbergerem@1def474

Or use the style of the left-hand column of the 'contacts' page and show links to the profile, photos and contacts. One could also show the number of photos/contacts just like the number of contacts on the 'contacts' page. (At the moment there is afaik no link back to the profile when you look at someones photos or contacts)

[Flaburgan]

I'm still in favor of putting the bio / location / gender first. Display the number is a good idea. To use the contacts page style is better than to put it in the title in my opinion. So The solution could be something like that:

[DeadSuperHero]

I really like the last one posted! Definitely makes a good use of space.

On Wednesday, August 7, 2013, Antoine D. wrote:

I'm still in favor of putting the bio / location / gender first. Display
the number is a good idea. To use the contacts page style is better than to
put it in the title in my opinion. So The solution could be something like
that:

[image: profile sidebar]https://f.cloud.github.com/assets/930064/922903/42c4b41a-ff37-11e2-85b9-3b6b3dd70ca1.PNG

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/4347#issuecomment-22235548
.

[carolinagc]

we've done the update with @Flaburgan suggestions, though actually was almost our original proposal :-P ... but for translation reasons (the text in the locale en.yml), we just put "View all"

[svbergerem]

I did something similar for the contacts: #4360

I'd like to see the number of photos just like @Flaburgan suggested and show the photos and 'see all'-link just like the avatars and 'see all'-link for contacts.

[Flaburgan]

If someone needs a hand for CSS just ping me here ;)

[carolinagc]

@Flaburgan what class are you using to show the photo count, so that it looks so nice :)

[Flaburgan]

contact_count. The interesting properties are border-radius: 4px; color: rgb(153, 153, 153); and background-color: rgb(238, 238, 238);

[svbergerem]

I suggest renaming it as we use it on both contacts and photos

[goobertron]

I like Florian's one (similar to Carolina's first with the addition of 'Show more photos' or 'View photos').

Would it be possible to have the photos overlaid on the page in a 'lightbox', so a user doesn't have to leave the profile page to view photos? That would be rather nice (although it's a separate issue).

I've left a comment on the issue for the contacts, as there's a potential privacy leak there we might need to discuss.

[juliaguar]

This is how the version in the pull request looks like:

[Flaburgan]

What about moving the link "show more" to the right?

[juliaguar]

We were thinking about doing that, but someone else did a pull request (#4360) to change the contacts on the profile page, and there the link is moved to the right. Those changes will also apply to our PR, won't they?

[svbergerem]

@juliaguar My PR doesn't move the link to the right. It does the same refactoring of contact_count that your PR does and doesn't change anything else in the stylesheets so my PR won't affect the style of your link.