Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery links don't work on Mozilla Firefox #8352

Closed
Cesese opened this issue May 4, 2022 · 3 comments · Fixed by #8400
Closed

Gallery links don't work on Mozilla Firefox #8352

Cesese opened this issue May 4, 2022 · 3 comments · Fixed by #8400
Milestone

Comments

@Cesese
Copy link

Cesese commented May 4, 2022

Versions

Diaspora* 0.7.15.0 / 0.7.16.0 (I tried on 2 different pods)
Mozilla Firefox for Arch Linux 100.0 (64-bit)

Problem

I use Firefox, and a friend of mine uses Safari. Both of us aren't logged in.

I didn't try on a pod on latest version (0.8.0.0) but I don't see anything in the changelog implying that this was fixed.

@goobertron
Copy link

goobertron commented May 5, 2022

I think that the problem is not with Firefox but that you're trying to view invalid links to images.

I believe that image files themselves aren't federated to remote servers; that is, they're not stored on any server except the one the account that uploads them is based on. So, when you view an image on a remote pod, your pod fetches the image from the poster's server.

If you visit the account in question in your pod, then select the Photos tab, find the photo you want and select 'View image in new tab' from Firefox's floating menu, you'll get a link to that account's home pod that ends in .jpg – which is what links to images look like: https://originating-pod.tlf/uploads/images/[guid].jpg.

And I think that is the only way to share a direct link to an image rather than a post with an image in it (which is what the working link you posted is). I don't think the links you posted would work in any browser.

So I'm pretty sure there's no bug here, just an attempt to share images in a way that's no intended to work.

@Cesese
Copy link
Author

Cesese commented May 5, 2022

It's not a direct link to the picture my friend wanted to send me, but a link to the post. Also this issue is specific to firefox, they tried the link on their phone before sending it to me and it worked.

If the gallery links are really invalid, then why do they work on my friend's phone? And why don't they show an error instead of a blank page?

Screenshot of the phone's web browser showing the post correctly without being logged in

@goobertron
Copy link

The first two links you posted are not valid links to a post but to an image, which is not usually viewable that way. If they wanted to send you a link to the post, then https://iviv.hu/posts/609670 would have been the correct link; or, even better, click on the timestamp on that post to reveal the post's guid – https://iviv.hu/posts/59ee0f90856d013a52cb543d7eeced27 – and send that to you so that you could view it in your own pod.

I've just looked into this a bit further and indeed it is possible to view an image directly in a phone browser without being signed in to that pod – and I don't think this is supposed to happen, especially if the image was uploaded to a limited-scope post.

And the browser in which the links 'worked' on my phone was Firefox, whereas I've tried Firefox, Opera and Safari on desktop with no success, so it's not an issue specific to a browser but to a platform, and is perhaps a weakness in the mobile version of the site.

Why the pages are blank on desktop rather than being a 404 or other error, I'm not sure, but I don't think such links have ever worked on desktop, and indeed I don't think it's possible to generate such links to images on desktop – as I said before, when I tried it, I got a link ending .jpg to the image on the host server.

Thanks for raising it.

SuperTux88 added a commit to SuperTux88/diaspora that referenced this issue Oct 7, 2022
This URL is only used in the mobile UI, but when somebody then copies
the link and sends it to somebody on the desktop UI, they don't see
anything. So lets just redirect to the post containing the photo, so
there is at least something to show.

If there is no linked post, just redirect to the image instead.

Fixes diaspora#8352
@SuperTux88 SuperTux88 added this to the 1.0.0 milestone Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants