dirty solution to fix (little bit) aspect_listing functionality #3194

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
7 participants
Contributor

visualsayed commented Apr 27, 2012

i hope this help.
thanks
sayed

This pull request fails (merged 71cd41b into 562e664).

Contributor

visualsayed commented May 1, 2012

first, i wanna thank #raven24 very much.
second, this pull request shows the problem, but should not be taken as the solution.

Owner

Raven24 commented May 1, 2012

we just discussed this on IRC,
the commit that broke the functionality is bfe0b71
this is related to issue #2704

Owner

DeadSuperHero commented May 1, 2012

Thanks for the info, Raven!

@visualsayed , would you be up for tackling this more in detail, now that you can see where the big change that caused this happened?

Owner

maxwell commented May 6, 2012

Still understand this fixes the problem. Still have not looked close enough to figure out why...

Contributor

visualsayed commented May 7, 2012

i'm still working on more elegant solution.

Owner

DeadSuperHero commented May 14, 2012

What's the status on this bad boy?

Owner

maxwell commented May 14, 2012

@DeadSuperHero maybe we could call for help for this pull in BMM?

Owner

maxwell commented May 17, 2012

hows it going?

Owner

maxwell commented May 29, 2012

Any luck?

Contributor

visualsayed commented May 30, 2012

I,m really sorry for dealyed answer but i was ill and i will keep working on this as soon as possible.

I've just started using diaspora and immediately noticed this bug. What needs to be done for this to get pulled?

Owner

Raven24 commented Aug 20, 2012

@amcinnes most importantly: rspec and maybe cucumber tests (so that this shall never break again).
As a big bonus a little refactoring couldn't hurt, but right now this should get fixed asap.

Owner

DeadSuperHero commented Oct 21, 2012

Any word on this? Do we just need tests for it?

Owner

Raven24 commented Oct 21, 2012

pretty much, yeah. also, not sure if that's the correct place for those changes.

Owner

jhass commented Nov 25, 2012

Fixed by #3737, closing. @visualsayed thank you anyway!

Btw. since you committed to master, if you want to make it clean it again:

git remote add upstream git://github.com/diaspora/diaspora.git #if not done already
git checkout master
git branch -m master aspect_listing_fix
git fetch upstream
git checkout -b master upstream/master
git checkout -b develop upstream/develop
git push origin master develop aspect_listing_fix

@jhass jhass closed this Nov 25, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment