dirty solution to fix (little bit) aspect_listing functionality

[visualsayed]

i hope this help.
thanks
sayed

[travisbot]

This pull request fails (merged 71cd41b into 562e664).

[visualsayed]

first, i wanna thank #raven24 very much.
second, this pull request shows the problem, but should not be taken as the solution.

[Raven24]

we just discussed this on IRC,
the commit that broke the functionality is bfe0b71
this is related to issue #2704

[DeadSuperHero]

Thanks for the info, Raven!

@visualsayed , would you be up for tackling this more in detail, now that you can see where the big change that caused this happened?

[maxwell]

Still understand this fixes the problem. Still have not looked close enough to figure out why...

[visualsayed]

i'm still working on more elegant solution.

[DeadSuperHero]

What's the status on this bad boy?

[maxwell]

@DeadSuperHero maybe we could call for help for this pull in BMM?

[maxwell]

hows it going?

[maxwell]

Any luck?

[visualsayed]

I,m really sorry for dealyed answer but i was ill and i will keep working on this as soon as possible.

[amcinnes]

I've just started using diaspora and immediately noticed this bug. What needs to be done for this to get pulled?

[Raven24]

@amcinnes most importantly: rspec and maybe cucumber tests (so that this shall never break again).
As a big bonus a little refactoring couldn't hurt, but right now this should get fixed asap.

[DeadSuperHero]

Any word on this? Do we just need tests for it?

[Raven24]

pretty much, yeah. also, not sure if that's the correct place for those changes.

[jhass]

Fixed by #3737, closing. @visualsayed thank you anyway!

Btw. since you committed to master, if you want to make it clean it again:

git remote add upstream git://github.com/diaspora/diaspora.git #if not done already
git checkout master
git branch -m master aspect_listing_fix
git fetch upstream
git checkout -b master upstream/master
git checkout -b develop upstream/develop
git push origin master develop aspect_listing_fix