Feature/2704 fix aspects

[francesmcmullin]

So I started out trying to improve on the changes by visualsayed in #3194 but it turns out changing things on the ruby / rails side was a total red herring, the problem was/is that none of the correct Aspect javascript was being activated, because the name of the page, at some point, changed from "AspectsIndex" to "StreamsAspects", presumably when the streams controller started taking over from other controllers.

Anyway, all that was need to fix #2704 was to rename the javascript file / page. I've also added a new cucumber test that fails without these changes, and slightly altered the behaviour of the "deselect all" link, because it annoyed me. If anyone has a better way to clear the stream, or thinks it's a bad idea, just say so =)

[francesmcmullin]

no idea why Travis failed, the log just stops after "installing database_cleaner (0.9.1)", and the mysql cucumber run passed, so if someone has access to a magic rebuild button, I'd appreciate a second run =)

[DeadSuperHero]

This looks good, and the build has passed. If there are no objections, I'd like to merge this. :)

[francesmcmullin]

just to explain what I was talking about with the deselect all behaviour, after the first commit, clicking deselect all will deselect all, but it's confusing because neither the stream nor the link change. You can click deselect all again, and then the page refreshes and all aspects are selected. With my change, (third commit) the link toggles to say select all, and the stream is emptied. I can see the argument against emptying the stream and I'm happy to leave that out if people want, but the link should definitely toggle =)

Happy to squash the commits / rebase / make other changes if requested

[DeadSuperHero]

I'm gonna test this on my localpod really quick to see how this stacks up. It'd be really nice if we could get the functionality we had back before the move over to Backbone. The specific functionality allowed users to click to add/subtract Aspects to the existing stream, rather than filtering them one at a time. I dunno if we'd ever want to have an empty stream, but I think keeping the "Select All" option is important. Maybe we could set it up so that deselecting "Select All" could fall back to the topmost Aspect to filter through?

[francesmcmullin]

I totally agree this is a great feature to fix, it's something I really
missed after it stopped working and was always disappointed that google had
nothing similar (one circle at a time, why?)

To clarify, with my changes it all works again. "deselect all"only appears
when all aspects are selected, it is a convenience for when you want to go
from all aspects to a specific aspect, but it should definitely toggle
(that's how the behaviour works already) and IMO the stream should be empty
when none are selected, it will fill again as soon as something is selected.

this is a bit tricky to explain in words, if people don't have time to test
drive the changes I can post screenshots to make things clearer.
On 2012-11-20 10:56 PM, "Sean Tilley" notifications@github.com wrote:

I'm gonna test this on my localpod really quick to see how this stacks up.
It'd be really nice if we could get the functionality we had back before
the move over to Backbone. The specific functionality allowed users to
click to add/subtract Aspects to the existing stream, rather than filtering
them one at a time. I dunno if we'd ever want to have an empty stream, but
I think keeping the "Select All" option is important. Maybe we could set it
up so that deselecting "Select All" could fall back to the topmost Aspect
to filter through?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3737#issuecomment-10577711.

[jaywink]

This would be awesome. A couple of guys at our company who I've demoed Diaspora* to, one of the first comments was "only one aspect at a time?".. The other was "so all aspects are always selected when stream is loaded?" ;)

[jhass]

I can haz a changelog update please? :)

[francesmcmullin]

changelog update added =)

[jhass]

Awesome, thanks!