Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ask for confirmation when leaving a submittable publisher #5309

Merged
merged 1 commit into from Nov 6, 2014
Merged

Ask for confirmation when leaving a submittable publisher #5309

merged 1 commit into from Nov 6, 2014

Conversation

svbergerem
Copy link
Member

Fixes #4235, supersedes #4418 and #4645.

For more information on beforeunload see
https://developer.mozilla.org/en-US/docs/Web/Events/beforeunload
https://developer.mozilla.org/en-US/docs/WindowEventHandlers.onbeforeunload

Note that in Firefox 4 and later the returned string is not displayed to the user. Instead, Firefox displays the string "This page is asking you to confirm that you want to leave - data you have entered may not be saved."

@svbergerem svbergerem changed the title Ask for confirmation when leaving a submittable publisher [WIP] Ask for confirmation when leaving a submittable publisher Oct 9, 2014
@svbergerem svbergerem force-pushed the confirm-unload-publisher branch 6 times, most recently from 23986ed to 7039398 Compare October 18, 2014 18:41
@svbergerem svbergerem changed the title [WIP] Ask for confirmation when leaving a submittable publisher Ask for confirmation when leaving a submittable publisher Oct 18, 2014
@svbergerem
Copy link
Member Author

Ready to review.

@jaywink
Copy link
Contributor

jaywink commented Nov 6, 2014

Looks good to me, and since no comments in 19 days, merging.

Thanks @svbergerem !

jaywink added a commit that referenced this pull request Nov 6, 2014
@jaywink
Merge pull request #5309 from svbergerem/confirm-unload-publisher
cd4502f 
Ask for confirmation when leaving a submittable publisher
@jaywink jaywink merged commit cd4502f into diaspora:develop Nov 6, 2014
@jaywink jaywink added this to the next-major milestone Nov 6, 2014
@svbergerem svbergerem deleted the confirm-unload-publisher branch November 6, 2014 20:45
This was referenced Nov 6, 2014
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0.0
Development

Successfully merging this pull request may close these issues.

Prevent user from leaving the page if there's content in the publisher
2 participants
@svbergerem @jaywink