Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Areyousure jquery added for monitoring URL change #4418

Closed
wants to merge 1 commit into from

Conversation

PallaviTS
Copy link
Contributor

Prevent user from leaving the page if there's content in the publisher

#4235

@jhass
Copy link
Member

jhass commented Aug 21, 2013

Please read https://help.github.com/articles/changing-author-info

Your change should probably go into the backbone view for the publisher.

A lot cucumber tests are failing: https://travis-ci.org/diaspora/diaspora/jobs/10450510#L2842 Please see https://wiki.diasporafoundation.org/Testing_workflow

@Flaburgan
Copy link
Member

@PallaviTS any news about that? We need this feature!

@qmaruf
Copy link
Contributor

qmaruf commented Dec 21, 2013

@PallaviTS any update about this? If there is no problem, I want to implement this.

@jaywink
Copy link
Contributor

jaywink commented Dec 21, 2013

@qmaruf just go for it :)

@qmaruf
Copy link
Contributor

qmaruf commented Dec 22, 2013

Is this functionality only for status box?

@jhass
Copy link
Member

jhass commented Dec 22, 2013

Might be neat for the new conversation pane, the conversation reply box, the new comment boxes and the email invite message box too, but since #4235 is only about the publisher, just doing it for that, is totally acceptable ;)

@qmaruf
Copy link
Contributor

qmaruf commented Dec 22, 2013

publisher is the status box, right?

@jhass
Copy link
Member

jhass commented Dec 22, 2013

Right. It's the publisher because it's for more than your status ;)

@jaywink
Copy link
Contributor

jaywink commented Nov 6, 2014

Superseded by #5309, thanks anyway for the time!

@jaywink jaywink closed this Nov 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants