Alter suggested bookmarklet to use Markdown #5384
Conversation
|
sorry, I always found that line very hard to read... |
|
Certainly. What I'll do is make a new set of commits, that first breaks up the bookmark into multiple lines, then changes it. |
JesseWeinstein
force-pushed
the
patch-1
branch
from
f0db1f4
to
aec00f8
Compare
To improve the readabilit of diffs that modify it, per diaspora#5384 (comment)
Switch to using content parameter, which doesn't alter its value, unlike the other ones. Use a H2 header for the document.title, quote the selected text, and put the URL at the bottom, in a separate paragraph.
Intentionally do a converting-comparison against the empty string, to see if text is selected.
|
OK, I've re-done the commit, off current develop, first by dividing the existing literal into separate lines, then making my changes (which I also broke into two commits, for readability). I look forward to your review! |
|
Tested this with iceweasel 33.1: selected text: no selected text: |
|
Hm, it looks like the newlines didn't take, for some reason. I'll test further. |
|
@JesseWeinstein Hey, still want to look into it or shall we put this up for adoption? |
|
I'm still interested, but I'd be delighted if someone with more knowledge of the codebase could look into it too. |
|
superseded by #5904 |
Switch it to use the content parameter, which doesn't alter the results, and insert some basic Markdown (header for the title, block quote for the selected text (still need to handle the case of no-selection better)) and put the URL at the end.