improved handling of reshares with deleted root-post #5968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
|
|
||
| it("provides isReshare and be true when the post is a reshare", function(){ | ||
| this.post.set({post_type : "Reshare"}); |
There was a problem hiding this comment.
Identifier 'post_type' is not in camel case.
SuperTux88
force-pushed
the
deleted-reshare-improvements
branch
from
4cd111f
to
61bc9a6
Compare
| <p> | ||
| {{t "stream.original_post_deleted"}} | ||
| </p> | ||
| </div> |
There was a problem hiding this comment.
I'd say instead of duplicating the tag, just pull it outside the if/else.
SuperTux88
force-pushed
the
deleted-reshare-improvements
branch
from
61bc9a6
to
1da1c53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.